Refine test ESLint envs, split RCE/tasks, add ts-mockito types

- Scope Mocha to all tests; Node only for desktop; Browser only for web
- Simplify ESLint test globs; keep common mocha override for non-env tests
- Split tasks_and_rce into tasks.simple and rce.simple; update web/desktop indices
- Add minimal ts-mockito ambient types (anyString, spy, capture.) with rationale
- Fix utils.test type errors; remove old combined test

Author: frogneko

.github/workflows/tests.yml

@@ -29,9 +29,9 @@ jobs:
             - name: Cache VS Code test downloads
               uses: actions/cache@v4
               with:
-                key: neuropilot-tests-vscode-v2-${{ github.repository }}-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
+                key: neuropilot-tests-vscode-${{ github.repository }}-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
                 restore-keys: |
-                  neuropilot-tests-vscode-v2-${{ github.repository }}-${{ runner.os }}-
+                  neuropilot-tests-vscode-${{ github.repository }}-${{ runner.os }}-
                 path: .vscode-test/
             - name: Setup pnpm
               uses: pnpm/action-setup@v4
@@ -50,8 +50,6 @@ jobs:
             - name: Run desktop tests (macOS/Windows)
               run: pnpm run test:desktop
               if: runner.os != 'Linux'
-            # for now we'll stop with this
-            # VSC-NeuroPilot/actions/send-test-repo-action will be added later
 
     web-tests:
         name: Web tests (browser matrix)
@@ -89,16 +87,3 @@ jobs:
               run: pnpm run build:web && pnpm run test:web:browser:esbuild
             - name: Run web tests (headless)
               run: pnpm exec vscode-test-web --headless --browser=${{ matrix.browser }} --extensionDevelopmentPath=. --extensionTestsPath=out/web/test/browser.js test-playground
-    #test-web:
-    #    name: Web tests
-    #    strategy:
-    #      fail-fast: false
-    #      matrix:
-    #        include:
-    #            - engine: webkit
-    #              browser: Safari
-    #            - engine: firefox
-    #              browser: Firefox
-    #            - engine: chromium
-    #              browser: Chrome
-    #    runs-on: ubuntu-latest

eslint.config.mjs

@@ -97,13 +97,30 @@ export default tseslint.config(
     },
     {
         files: ['src/test/**/*.ts'],
+        languageOptions: {
+            globals: {
+                ...globals.mocha,
+            },
+        },
+    },
+    {
+        files: ['src/test/suite/desktop/**/*.ts', 'src/test/test_utils.ts'],
         languageOptions: {
             globals: {
                 ...globals.node,
                 ...globals.mocha,
             },
         },
     },
+    {
+        files: ['src/test/suite/web/**/*.ts'],
+        languageOptions: {
+            globals: {
+                ...globals.browser,
+                ...globals.mocha,
+            },
+        },
+    },
     {
         files: ['**/*.{js,mjs,cjs}', 'eslint.config.mjs', 'esbuild.mjs', '**/*.esbuild.{m,c,}js'],
         plugins: {

src/test/suite/desktop/index.ts

@@ -22,7 +22,8 @@ import '../../unit-test/place_cursor.simple.test';
 import '../../unit-test/replace_text.simple.test';
 import '../../unit-test/rewrite_all.simple.test';
 import '../../unit-test/rewrite_lines.simple.test';
-import '../../unit-test/tasks_and_rce.simple.test';
+import '../../unit-test/tasks.simple.test';
+import '../../unit-test/rce.simple.test';
 import '../../unit-test/terminal.simple.test';
 import '../../unit-test/undo_and_save.simple.test';
 

src/test/suite/web/index.ts

@@ -35,7 +35,8 @@ import '../../unit-test/place_cursor.simple.test';
 import '../../unit-test/replace_text.simple.test';
 import '../../unit-test/rewrite_all.simple.test';
 import '../../unit-test/rewrite_lines.simple.test';
-import '../../unit-test/tasks_and_rce.simple.test';
+import '../../unit-test/tasks.simple.test';
+import '../../unit-test/rce.simple.test';
 import '../../unit-test/undo_and_save.simple.test';
 
 // Testing the meta stuff

src/test/unit-test/rce.simple.test.ts

@@ -0,0 +1,17 @@
+import * as assert from 'assert';
+import { cancelRequestAction } from '@/rce';
+
+// Tests for RCE action prompt generators using real logic
+suite('rce Actions', () => {
+    test('cancel_request has empty prompt', () => {
+        // === Arrange & Act ===
+        const prompt = (cancelRequestAction.promptGenerator as () => string)();
+
+        // === Assert ===
+        assert.ok(typeof prompt === 'string');
+        assert.strictEqual(prompt.length, 0);
+    });
+});
+
+
+

src/test/unit-test/tasks.simple.test.ts

@@ -0,0 +1,16 @@
+import * as assert from 'assert';
+import { taskHandlers } from '@/tasks';
+
+// Tests for tasks action prompt generators using real logic
+suite('tasks Actions', () => {
+    test('terminate_task fixed prompt', () => {
+        // === Arrange & Act ===
+        const prompt = taskHandlers.terminate_task.promptGenerator as string;
+
+        // === Assert ===
+        assert.ok(typeof prompt === 'string' && prompt.length > 0);
+    });
+});
+
+
+

src/test/unit-test/tasks_and_rce.simple.test.ts

@@ -1,11 +1,33 @@
-// Minimal ambient declarations for ts-mockito to satisfy type-checking in tests
+/*
+Minimal ambient declarations for ts-mockito to satisfy type-checking in tests
+Why this exists:
+- ts-mockito ships its own type definitions, but our web test TypeScript config
+  (see test-tsconfigs/tsconfig.web.json) targets WebWorker libs and intentionally
+  omits Node types. The official ts-mockito typings may pull in Node types, which
+  would force us to enable `node` types/globals for web tests.
+- Enabling Node types in the web config is undesirable, since it pollutes the
+  browser-targeted environment with Node globals.
+
+This ambient declaration only exposes the subset of ts-mockito APIs we use with
+permissive types. It keeps both desktop and web test builds type-clean without
+adding Node typings to the web configuration.
+
+If you remove this file, consider either:
+- adding `node` to `types` in test-tsconfigs/tsconfig.web.json; or
+- excluding ts-mockito-dependent tests from the web runner.
+*/
 declare module 'ts-mockito' {
     export function mock<T>(clazz?: new (...args: any[]) => T): T;
     export function instance<T>(mocked: T): T;
     export function verify<T>(value: any): any;
-    export function capture<T>(value: any): { last(): [any, ...any[]] };
+    export function capture<T>(value: any): {
+        first(): [any, ...any[]];
+        second(): [any, ...any[]];
+        third(): [any, ...any[]];
+        last(): [any, ...any[]];
+    };
     export function anything(): any;
+    export function anyString(): string;
+    export function spy<T>(instance: T): T;
     export function reset<T>(mocked: T): void;
 }
-
-