Skip to content

Commit 683ff63

Browse files
committed
fix: resolve CI failures — eslint resolution, prisma pnpm compat, lint job
- Add auto-install-peers=true to .npmrc for proper peer dep resolution - Add build:packages step before lint in CI to ensure import resolver works - Add eslint and @veridion/eslint-config as direct devDeps to packages that use eslint (database, logger, ui, api) - Fix db:generate with symlink for pnpm + prisma type resolution - Revert npx eslint to eslint in api lint scripts
1 parent c16efc7 commit 683ff63

6 files changed

Lines changed: 26 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
node-version: 20
2525
cache: 'pnpm'
2626
- run: pnpm install --frozen-lockfile
27+
- run: pnpm build:packages
2728
- run: pnpm format:check
2829
- run: pnpm lint
2930

.npmrc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
public-hoist-pattern[]=*react*
22
public-hoist-pattern[]=*react-dom*
3-
public-hoist-pattern[]=*eslint*
4-
public-hoist-pattern[]=*prisma*
53
auto-install-peers=true

packages/database/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"test": "vitest run",
1414
"test:watch": "vitest",
1515
"clean": "rm -rf dist",
16-
"db:generate": "npx prisma generate && ln -sf ../.prisma node_modules/@prisma/client/.prisma",
16+
"db:generate": "npx prisma generate && ln -sfn ../.prisma node_modules/@prisma/client/.prisma",
1717
"db:migrate": "prisma migrate dev",
1818
"db:push": "prisma db push",
1919
"db:seed": "tsx prisma/seed.ts",
@@ -23,7 +23,9 @@
2323
"@prisma/client": "^5.14.0"
2424
},
2525
"devDependencies": {
26+
"@veridion/eslint-config": "workspace:*",
2627
"@veridion/tsconfig": "workspace:*",
28+
"eslint": "^8.57.0",
2729
"prisma": "^5.14.0",
2830
"tsx": "^4.11.0",
2931
"typescript": "^5.4.5",

packages/logger/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@
2323
},
2424
"devDependencies": {
2525
"@types/node": "^20.12.12",
26+
"@veridion/eslint-config": "workspace:*",
2627
"@veridion/tsconfig": "workspace:*",
28+
"eslint": "^8.57.0",
2729
"typescript": "^5.4.5",
2830
"vitest": "^1.6.0"
2931
}

packages/ui/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@
2424
},
2525
"devDependencies": {
2626
"@types/react": "^18.3.3",
27+
"@veridion/eslint-config": "workspace:*",
2728
"@veridion/tsconfig": "workspace:*",
29+
"eslint": "^8.57.0",
2830
"react": "^18.3.1",
2931
"typescript": "^5.4.5"
3032
}

pnpm-lock.yaml

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)