A simpler solution for the macro in "Non-Identifier Identifiers" and terseness/on-topic problem

[studyingegret]

Link

Another way to fix this

macro_rules! make_self_mutable {
    ($i:ident) => {let mut $i = self;};
}

is

macro_rules! make_self_mutable {
    ($i:ident, $v:ident) => {let mut $i = $v;};
}

(playground)

And I think the section lacks a conclusion of when self is

• matched as a ident: always?
• matched as a pat: never?
• hygiened as a keyword/identifier: as a keyword unless the incoming context suggests otherwise?

and went on to talk about a lot of failing solutions while the essence of the problem seems to be with contextual matching of self as ident

[Veykril]

Another way to fix this

macro_rules! make_self_mutable {
($i:ident) => {let mut $i = self;};
}

is

macro_rules! make_self_mutable {
($i:ident, $v:ident) => {let mut $i = $v;};
}

(playground)

And I think the section lacks a conclusion of when self is

* matched as a `ident`: always?

* matched as a `pat`: never?

* hygiened as a keyword/identifier: as a keyword unless the incoming context suggests otherwise?

and went on to talk about a lot of failing solutions while the essence of the problem seems to be with contextual matching of self as ident

That section is not about "fixing" that issue, its written deliberately that way to show how self behaves weirdly in comparison to other keywords or identifiers.

[studyingegret]

If it's deliberately written to display the difference between self and other things, then the only thing I can say is that I didn't perceive it that way. To me it really looks like trying a different solution since I got distracted by shifting to let the macro take the whole method expr (without explanation).

In my opinion, I'd put my make_self_mutable code after the docs' (failing) make_self_mutable, change the double_method! {_, 0} code to make_self_mutable!(_, self) to demonstrate the behavior of matching _ as ident, and put the ($body:expr), ($self_:ident, $body:expr) (2 samples) after all that, because regarding macro behavior their essential problem seem to repeat with the previous examples. (The ($self_:ident, $body:expr) one is arguably better than make_self_mutable in the sense that the user can just write self but it's a non-macro problem (self not allowed to be a match pattern).)

[studyingegret]

And I think the section lacks a conclusion of when self is

• matched as a ident: always?

Oops, maybe it's my oversight

However, it also happens to fit the definition of an identifier.

Or I think a link to this will be better