Merge pull request #183 from WEBcodeX1/arduino

Cosmetical, remove comments

Author: clauspruefer

lib/http/httpparser.cpp

@@ -33,7 +33,6 @@ void HTTPParser::appendBuffer(const char* BufferRef, const uint16_t RecvBytes)
     if (_POSTWaitContentLength == true && _HTTPRequestBuffer.length() >= _POSTContentLength) {
         _RequestProperties.Payload = _HTTPRequestBuffer.substr(0, _POSTContentLength);
         _HTTPRequestBuffer.replace(0, _POSTContentLength, "");
-        //_Requests.push_back(_RequestProperties);
         _Requests.emplace(_ReqAddIndex, _RequestProperties);
         _ReqAddIndex += 1;
         _POSTWaitContentLength = false;
@@ -120,7 +119,6 @@ inline bool HTTPParser::_processRequestProperties(const size_t Index)
         _parseGETParameter(_RequestProperties.URL, _RequestProperties.URLParams);
 
         //- add request to requests map
-        //_Requests.push_back(_RequestProperties);
         _Requests.emplace(_ReqAddIndex, _RequestProperties);
         _ReqAddIndex += 1;
     }
@@ -152,7 +150,6 @@ inline bool HTTPParser::_processRequestProperties(const size_t Index)
                 _RequestProperties.Payload = _HTTPRequestBuffer.substr(0, _POSTContentLength);
                 _HTTPRequestBuffer.replace(0, _POSTContentLength, "");
                 //- add request to requests map
-                //_Requests.push_back(_RequestProperties);
                 _Requests.emplace(_ReqAddIndex, _RequestProperties);
                 _ReqAddIndex += 1;
             }
@@ -168,7 +165,6 @@ inline bool HTTPParser::_processRequestProperties(const size_t Index)
                 _RequestProperties.Payload = NextRequest.substr(0, _POSTContentLength);
                 NextRequest.replace(0, _POSTContentLength, "");
                 //- add request to requests map
-                //_Requests.push_back(_RequestProperties);
                 _Requests.emplace(_ReqAddIndex, _RequestProperties);
                 _ReqAddIndex += 1;
             }

lib/http/httpparser.hpp

@@ -102,31 +102,28 @@ class StringHelper {
         size_t FindPos = 0;
         size_t FindPosLast = 0;
         string Token;
-        // Guard: if StartPos is smaller than the delimiter length, a plain
-        // subtraction would underflow (size_t is unsigned).  Just return the
-        // substring up to StartPos as the sole token.
+
         if (StartPos < Delimiter.length()) {
             ResultRef.push_back(String.substr(0, StartPos));
             return;
         }
+
         StartPos -= Delimiter.length();
+
         while ((FindPos = String.rfind(Delimiter, StartPos)) != String.npos) {
+
             Token = String.substr(FindPos+Delimiter.length(), (StartPos-FindPos));
             ResultRef.push_back(Token);
-            // Guard: if the delimiter sits at the very start (or closer to the
-            // start than its own length), another subtraction would underflow.
-            // Record the position and break; the final substr(0, FindPosLast)
-            // below will correctly capture the token before this delimiter.
+
             if (FindPos < Delimiter.length()) {
                 FindPosLast = FindPos;
                 break;
             }
+
             StartPos = FindPos - Delimiter.length();
             FindPosLast = FindPos;
         }
-        // Push the leading token: the substring from 0 up to the position of
-        // the last delimiter found (FindPosLast), which is 0 when no delimiter
-        // was found (producing an empty string as the sentinel).
+
         Token = String.substr(0, FindPosLast);
         ResultRef.push_back(Token);
     }

test/unit/http-parser/test-parser-requests.cpp

@@ -536,9 +536,9 @@ BOOST_AUTO_TEST_CASE( test_urlparamsmap2_json )
 }
 
 
-// =========================================================================
+// ======================================================================
 // Category 1: Malformed headers (missing space or disallowed characters)
-// =========================================================================
+// ======================================================================
 
 BOOST_AUTO_TEST_CASE( test_malformed_header_missing_space_after_colon )
 {
@@ -986,9 +986,9 @@ BOOST_AUTO_TEST_CASE( test_binary_file_kmod_byte_by_byte )
 }
 
 
-// =========================================================================
+// ===========================================================================
 // Category 5: Requests designed to stress-test / potentially crash the parser
-// =========================================================================
+// ===========================================================================
 
 BOOST_AUTO_TEST_CASE( test_crash_request_line_method_only )
 {