Count fetched MR/PR items in /check missing logic

Author: Codex

internal/integrations/slack/slack.go

@@ -867,6 +867,14 @@ func handleListMissing(api *slack.Client, db *sql.DB, cfg Config, cmd slack.Slas
 	}
 
 	monday, nextMonday := ReportWeekRange(cfg, time.Now().In(cfg.Location))
+	weekItems, err := GetItemsByDateRange(db, monday, nextMonday)
+	if err != nil {
+		postEphemeral(api, cmd, fmt.Sprintf("Error loading items: %v", err))
+		log.Printf("list-missing load error: %v", err)
+		return
+	}
+	reportedAuthors := uniqueReportedAuthors(weekItems)
+
 	reportedAuthorIDs, err := GetSlackAuthorIDsByDateRange(db, monday, nextMonday)
 	if err != nil {
 		postEphemeral(api, cmd, fmt.Sprintf("Error loading items: %v", err))
@@ -881,11 +889,22 @@ func handleListMissing(api *slack.Client, db *sql.DB, cfg Config, cmd slack.Slas
 	var missing []missingMember
 	var missingIDs []string
 	for _, uid := range memberIDs {
-		if reportedAuthorIDs[uid] {
+		user, err := api.GetUserInfo(uid)
+		nameCandidates := []string{uid}
+		if err == nil {
+			if user.Profile.DisplayName != "" {
+				nameCandidates = append(nameCandidates, user.Profile.DisplayName)
+			}
+			if user.RealName != "" {
+				nameCandidates = append(nameCandidates, user.RealName)
+			}
+			if user.Name != "" {
+				nameCandidates = append(nameCandidates, user.Name)
+			}
+		}
+		if memberReportedThisWeek(uid, nameCandidates, reportedAuthorIDs, reportedAuthors) {
 			continue
 		}
-
-		user, err := api.GetUserInfo(uid)
 		if err != nil {
 			missing = append(missing, missingMember{display: uid, userID: uid})
 			missingIDs = append(missingIDs, uid)
@@ -963,6 +982,38 @@ func handleListMissing(api *slack.Client, db *sql.DB, cfg Config, cmd slack.Slas
 	log.Printf("list-missing count=%d", len(missing)+len(unresolved))
 }
 
+func uniqueReportedAuthors(items []WorkItem) []string {
+	seen := make(map[string]bool)
+	var out []string
+	for _, item := range items {
+		author := strings.TrimSpace(item.Author)
+		if author == "" || seen[author] {
+			continue
+		}
+		seen[author] = true
+		out = append(out, author)
+	}
+	return out
+}
+
+func memberReportedThisWeek(userID string, nameCandidates []string, reportedAuthorIDs map[string]bool, reportedAuthors []string) bool {
+	if reportedAuthorIDs[userID] {
+		return true
+	}
+	for _, candidate := range nameCandidates {
+		candidate = strings.TrimSpace(candidate)
+		if candidate == "" {
+			continue
+		}
+		for _, author := range reportedAuthors {
+			if strings.EqualFold(candidate, author) || nameMatches(candidate, author) || nameMatches(author, candidate) {
+				return true
+			}
+		}
+	}
+	return false
+}
+
 func postEphemeral(api *slack.Client, cmd slack.SlashCommand, text string) {
 	postEphemeralTo(api, cmd.ChannelID, cmd.UserID, text)
 }

internal/integrations/slack/slack_logic_test.go

@@ -183,6 +183,21 @@ func TestFormatItemDescriptionForList(t *testing.T) {
 	}
 }
 
+func TestMemberReportedThisWeek(t *testing.T) {
+	reportedIDs := map[string]bool{"U123": true}
+	reportedAuthors := []string{"Alex Rivera", "Jordan Patel"}
+
+	if !memberReportedThisWeek("U123", []string{"Alex Rivera"}, reportedIDs, reportedAuthors) {
+		t.Fatal("expected member to be reported when author_id is present")
+	}
+	if !memberReportedThisWeek("U999", []string{"Alex"}, map[string]bool{}, reportedAuthors) {
+		t.Fatal("expected fuzzy name match against fetched author to count as reported")
+	}
+	if memberReportedThisWeek("U999", []string{"Taylor"}, map[string]bool{}, reportedAuthors) {
+		t.Fatal("expected unmatched member name to be considered missing")
+	}
+}
+
 func TestDeriveBossReportFromTeamReport_FileExists(t *testing.T) {
 	dir := t.TempDir()
 	teamName := "TestTeam"