fix: avoids matching bigint when not single value of an object

Author: Gancho Radkov

misc/safe-json/src/index.ts

@@ -24,10 +24,8 @@ const JSONParse = (json: string) => {
     */
   // prettier-ignore
   // eslint-disable-next-line no-useless-escape
-  const numbersBiggerThanMaxInt = `/([\[:])?(?:(?!"[^"]*")(\d{17,}|(?:[9](?:[1-9]07199254740991|0[1-9]7199254740991|00[8-9]199254740991|007[2-9]99254740991|007199[3-9]54740991|0071992[6-9]4740991|00719925[5-9]740991|007199254[8-9]40991|0071992547[5-9]0991|00719925474[1-9]991|00719925474099[2-9])))([,\}\]])/g;`;
-
-  const serializedData = json.replace(numbersBiggerThanMaxInt, `$1"$2n"$3`);
-
+  const numbersBiggerThanMaxInt = /(?<!")(?<=:)\b(\d{17,}|(?:[9](?:[1-9]07199254740991|0[1-9]7199254740991|00[8-9]199254740991|007[2-9]99254740991|007199[3-9]54740991|0071992[6-9]4740991|00719925[5-9]740991|007199254[8-9]40991|0071992547[5-9]0991|00719925474[1-9]991|00719925474099[2-9])))(?=[,\}\]]|$)/g;
+  const serializedData = json.replace(numbersBiggerThanMaxInt, (match) => `"${match}n"`);
   return JSON.parse(serializedData, (_, value) => {
     const isCustomFormatBigInt = typeof value === "string" && value.match(/^\d+n$/);
 

misc/safe-json/test/index.test.ts

@@ -42,6 +42,13 @@ describe("@walletconnect/safe-json", () => {
       const result = safeJsonParse(nested);
       chai.expect(result).to.deep.eq(JSON.parse(nested));
     });
+
+    it("should handle BigInt", () => {
+      const bigIntId = "1702044452707006208";
+      const data = `{"id":${bigIntId},"jsonrpc":"2.0","result":"cb0072aaf3f3aab9b5a334f3a273634a2a6d2bee5fe7be205dc9f30f032c9734"}`;
+      const result = safeJsonParse(data);
+      chai.expect(result.id).to.deep.eq(BigInt(bigIntId));
+    });
   });
   describe("safeJsonStringify", () => {
     it("should return a stringfied json", () => {