Skip to content

fix: use full commit hash for CTA Assistant action - #248

Merged
bkrem merged 1 commit into
masterfrom
devin/1759158745-cta-assistant-fix
Sep 29, 2025
Merged

fix: use full commit hash for CTA Assistant action#248
bkrem merged 1 commit into
masterfrom
devin/1759158745-cta-assistant-fix

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

fix: use full commit hash for CTA Assistant action

Summary

Fixes the CTA Assistant workflow that was merged with a shortened commit hash causing CI failures. The original implementation used 7a3ca8b which GitHub Actions cannot resolve, now updated to the full commit hash 7a3ca8b03e62e9ab0df31f3a6d151386e5dd80bd. Also changes the trigger from pull_request_target to pull_request for consistent behavior with other workflows in the repository.

Review & Testing Checklist for Human

This is a medium risk fix for a production workflow handling legal compliance:

  • Verify commit hash: Confirm 7a3ca8b03e62e9ab0df31f3a6d151386e5dd80bd exists and points to the correct version of WalletConnect/actions/github/cta-assistant
  • Test workflow trigger: Open a test PR to verify the CTA workflow actually runs and completes successfully
  • Security review: Confirm changing from pull_request_target to pull_request is appropriate and doesn't introduce security risks for this workflow
  • End-to-end testing: Verify CTA signature collection process still works correctly with the updated action

Notes


Note

Pin CTA Assistant GitHub Action to a full commit SHA and adjust a permissions comment.

  • CI/CD:
    • CTA workflow (.github/workflows/cta.yml):
      • Pin WalletConnect/actions/github/cta-assistant from @7a3ca8b to @7a3ca8b03e62e9ab0df31f3a6d151386e5dd80bd.
      • Update comment describing required permissions.

Written by Cursor Bugbot for commit b8cbdc9. This will update automatically on new commits. Configure here.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@bkrem

bkrem commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

rebase onto latest master

- Replace shortened hash 7a3ca8b with full hash 7a3ca8b03e62e9ab0df31f3a6d151386e5dd80bd
- Fixes GitHub Actions workflow failure due to ambiguous commit reference
- Uses pull_request trigger for consistent behavior with other workflows

Co-Authored-By: Ben Kremer <ben@reown.com>
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1759158745-cta-assistant-fix branch from 66af115 to b8cbdc9 Compare September 29, 2025 15:18
@bkrem
bkrem merged commit 71b532b into master Sep 29, 2025
3 of 4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant