fix(call): prevent stale-data VideoCall mount and guard startRecording (#1226)

Key Stage by stage.id to eliminate the one-render window where
player.stage updates before useStage(), causing VideoCall to mount
with stale discussion config during stage transitions. Also guard
startRecording() return value to prevent TypeError crash if the
Daily SDK returns undefined in a transitional state.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: JamesPHoughton

client/src/Game.jsx

@@ -136,7 +136,7 @@ export function Game() {
         <Profile />
       </div>
       <div className="absolute top-12 left-0 right-0 bottom-0 m-2">
-        <Stage />
+        <Stage key={stage.id} />
       </div>
     </>
   );

client/src/call/hooks/useCallStartSignaling.js

@@ -34,28 +34,34 @@ export function useCallStartSignaling(callObject, recordingEnabled, stageId) {
     const startRecordingIfNeeded = () => {
       if (recordingEnabled && !recordingStartedRef.current) {
         recordingStartedRef.current = true;
-        callObject.startRecording({ type: "raw-tracks" }).then(
-          () => console.log("[Recording] Started raw-tracks recording from client"),
-          (err) => {
-            console.warn("[Recording] Failed to start recording:", err.message);
-            recordingStartedRef.current = false;
+        const result = callObject.startRecording({ type: "raw-tracks" });
+        if (result && typeof result.then === "function") {
+          result.then(
+            () => console.log("[Recording] Started raw-tracks recording from client"),
+            (err) => {
+              console.warn("[Recording] Failed to start recording:", err.message);
+              recordingStartedRef.current = false;
 
-            // Defer Sentry alert: wait 5s and check if another participant
-            // successfully started recording (indicated by recording-started
-            // event setting recordingConfirmedRef). This avoids false alarms
-            // when one client fails but another succeeds — Daily broadcasts
-            // recording-started to all participants regardless of who initiated.
-            const timer = setTimeout(() => {
-              if (!recordingConfirmedRef.current) {
-                Sentry.captureMessage("Recording not started for stage", {
-                  level: "error",
-                  extra: { triggeringError: err.message, stageId },
-                });
-              }
-            }, 5000);
-            pendingTimers.push(timer);
-          }
-        );
+              // Defer Sentry alert: wait 5s and check if another participant
+              // successfully started recording (indicated by recording-started
+              // event setting recordingConfirmedRef). This avoids false alarms
+              // when one client fails but another succeeds — Daily broadcasts
+              // recording-started to all participants regardless of who initiated.
+              const timer = setTimeout(() => {
+                if (!recordingConfirmedRef.current) {
+                  Sentry.captureMessage("Recording not started for stage", {
+                    level: "error",
+                    extra: { triggeringError: err.message, stageId },
+                  });
+                }
+              }, 5000);
+              pendingTimers.push(timer);
+            }
+          );
+        } else {
+          console.warn("[Recording] startRecording() returned non-Promise; call may be in transitional state");
+          recordingStartedRef.current = false;
+        }
       }
     };