fix: address PR review feedback

- Add meetingState === "joining" to joinRoom skip guard (prevents double-join)
- Fix debounce timer: don't push to inlineTimers (avoids hung promise on cleanup)
- Fix issue reference: #1226 not #1236
- Update cleanup comment to reflect actual behavior (skip leave during joining)
- Preserve "non-promise return" error string (matches existing test REC-005b)
- MockDailyProvider: transition state on non-delayed join path

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: JamesPHoughton

client/src/call/hooks/useCallLifecycle.js

@@ -88,18 +88,18 @@ export function useCallLifecycle(callObject, roomUrl, player) {
       // corrupting the callObject state for subsequent video stages.
       // 150ms is imperceptible to users but longer than any observed transient
       // mount, and long enough for the previous leave() to complete.
-      // See issue #1236.
+      // See issue #1226.
       await new Promise((resolve) => {
-        inlineTimers.push(setTimeout(resolve, 150));
+        setTimeout(resolve, 150);
       });
       if (unmountedRef.current) {
         console.log("[VideoCall] Join debounce: component unmounted during delay, skipping join");
         return;
       }
 
       const meetingState = callObject.meetingState?.();
-      if (meetingState === "joined-meeting" || joiningMeetingRef.current) {
-        console.warn("[VideoCall] joinRoom skipped — already in meeting or joining", {
+      if (meetingState === "joined-meeting" || meetingState === "joining" || joiningMeetingRef.current) {
+        console.warn("[VideoCall] joinRoom skipped", {
           meetingState,
           joiningMeetingRef: joiningMeetingRef.current,
         });
@@ -225,11 +225,12 @@ export function useCallLifecycle(callObject, roomUrl, player) {
       const state = callObject.meetingState?.();
 
       if (
-        // state === "joining" ||
         state === "joined-meeting" ||
         state === "loaded"
       ) {
-        // only leave if we are in the process of joining or already joined
+        // Only call leave() once the meeting has fully joined/loaded; we skip
+        // leave() for state === "joining" (handled below) to avoid forcing a
+        // leave mid-join.
         console.log("[VideoCall] Leaving Daily room", { state });
         callObject.leave();
       } else if (state === "joining") {

client/src/call/hooks/useCallStartSignaling.js

@@ -84,7 +84,7 @@ export function useCallStartSignaling(callObject, recordingEnabled, stageId) {
             if (!recordingConfirmedRef.current) {
               Sentry.captureMessage("Recording not started for stage", {
                 level: "error",
-                extra: { triggeringError: "non-promise return after retry", stageId, trigger },
+                extra: { triggeringError: "non-promise return", stageId, trigger },
               });
             }
           }, 5000);

playwright/mocks/daily/MockDailyProvider.jsx

@@ -107,6 +107,11 @@ class MockCallObject extends MockEventEmitter {
         };
       });
     }
+    // Non-delayed join: immediately transition to joined and emit event
+    if (this._meetingState !== 'joined-meeting') {
+      this._meetingState = 'joined-meeting';
+      this.emit('joined-meeting', {});
+    }
     return Promise.resolve();
   }