fix(icp-dapp-launcher): use production II URL and fix JS asset paths on IC (#271)

* fix(icp-dapp-launcher): use production II URL and fix JS asset paths on IC

Two bugs prevented correct production deployment:

1. deploy-launcher.sh ran `icp deploy` without first running `npm run build`.
   The `icp` tool only uploads the existing build/ directory — it never invokes
   Vite. So ICP_NETWORK=ic had no effect and PROD was always false, embedding
   the local dev II URL (rdmx6-jaaaa...) instead of https://id.ai.
   Fix: explicitly build with ICP_NETWORK=ic before deploying.

2. trailingSlash='ignore' caused SvelteKit to output launch.html with relative
   asset paths like ./_app/... The ICP HTTP gateway redirects /launch → /launch/
   (trailing slash) because files exist under /launch/. At /launch/, the paths
   resolve to /launch/_app/... which doesn't exist, so the asset canister
   returns its HTML fallback — causing the 'text/html' MIME type error on JS
   module scripts.
   Fix: trailingSlash='always' generates launch/index.html with ../_app/...
   paths that resolve correctly from /launch/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: bump pocket-ic crate to 13.0.0 to match server binary

Local PocketIC server binary is v13.0.0 but the workspace crate was
pinned to 12.0.0 (which rejects >=13). Bumping to 13.0.0 resolves the
version mismatch.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* chore: bump icp-dapp-launcher version (patch)

* fix(icp-dapp-launcher): hardcode mainnet canister IDs as fallback

wasm-registry and demos now default to mainnet IDs so local dev and
production both work without VITE_* env vars set. The VITE_* override
is kept for CI, where local canisters are deployed with different IDs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Web3NL

Cargo.lock

@@ -29,7 +29,7 @@ ic-ledger-types = "0.16.0"
 include_dir = "0.7.4"
 icrc-ledger-types = "0.1.12"
 mime_guess = "2.0.5"
-pocket-ic = "12.0.0"
+pocket-ic = "13.0.0"
 serde = { version = "1.0.228", features = ["derive"] }
 serde_cbor = "0.11.2"
 serde_json = "1.0.149"

Cargo.toml

@@ -1,11 +1,11 @@
 {
   "name": "icp-dapp-launcher",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "dependencies": {
     "@dfinity/gix-components": "^10.0.0",
     "@web3nl/my-canister-dashboard": "0.8.0"
   },
-  "deployedAtCommit": "3ccd54cd9ac462d4f2f358a4d2cac18bf2d86f82",
+  "deployedAtCommit": "8a47e4467cefcc80488edd65cc7042bdf975c351",
   "engines": {
     "node": ">=22.0.0"
   },

canisters/icp-dapp-launcher/package.json

@@ -3,7 +3,9 @@ export const INDEX_CANISTER_ID = 'qhbym-qaaaa-aaaaa-aaafq-cai';
 export const CMC_CANISTER_ID = 'rkp4c-7iaaa-aaaaa-aaaca-cai';
 
 export const WASM_REGISTRY_CANISTER_ID =
-  (import.meta.env.VITE_WASM_REGISTRY_CANISTER_ID as string) || '';
+  (import.meta.env.VITE_WASM_REGISTRY_CANISTER_ID as string) ||
+  'eeqt3-riaaa-aaaal-qbsva-cai';
 
 export const DEMOS_CANISTER_ID =
-  (import.meta.env.VITE_DEMOS_CANISTER_ID as string) || '';
+  (import.meta.env.VITE_DEMOS_CANISTER_ID as string) ||
+  'maqro-xqaaa-aaaal-qceuq-cai';

canisters/icp-dapp-launcher/src/lib/constants/canisterIds.ts

@@ -1,3 +1,3 @@
 export const prerender = true;
 export const ssr = false;
-export const trailingSlash = 'ignore';
+export const trailingSlash = 'always';

canisters/icp-dapp-launcher/src/routes/+layout.ts

@@ -26,9 +26,13 @@ if [[ -n $(git status --porcelain) ]]; then
     exit 1
 fi
 
-# Deploy the app (ICP_NETWORK=ic triggers production build)
+# Build the launcher for production — ICP_NETWORK=ic must be set during vite build
+# so the PROD constant is true at compile time (icp deploy does not run npm build)
+echo "🔨 Building icp-dapp-launcher for production..."
+(cd canisters/icp-dapp-launcher && ICP_NETWORK=ic npm run build)
+
 echo "🚢 Deploying to IC..."
-ICP_NETWORK=ic icp deploy icp-dapp-launcher -e mainnet --identity web3nl
+icp deploy icp-dapp-launcher -e mainnet --identity web3nl
 
 # Get current commit hash after successful deploy
 COMMIT_HASH=$(git rev-parse HEAD)