Skip to content

Commit b76fa26

Browse files
Web3NLclaude
andcommitted
fix: use same-origin-allow-popups for COOP header to support II popups
Cross-Origin-Opener-Policy: same-origin blocks communication between the dapp window and the Internet Identity popup (different canister origins). Change to same-origin-allow-popups which still protects against being opened by other origins but allows the dapp to open II authentication popups that can communicate back. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7279e14 commit b76fa26

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

packages-rs/canister-dapp-test/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ pub fn run_acceptance_suite(wasm_bytes: &[u8], wasm_label: &str) {
384384
assert_header_contains(
385385
&fallback_resp,
386386
"cross-origin-opener-policy",
387-
"same-origin",
387+
"same-origin-allow-popups",
388388
);
389389
assert_header_contains(
390390
&fallback_resp,

packages-rs/my-canister-frontend/src/asset_router.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,10 @@ fn create_default_headers(_content_type: &str) -> Vec<(String, String)> {
279279
"accelerometer=(), camera=(), geolocation=(), microphone=(), payment=(), usb=()"
280280
.into(),
281281
),
282-
("Cross-Origin-Opener-Policy".into(), "same-origin".into()),
282+
(
283+
"Cross-Origin-Opener-Policy".into(),
284+
"same-origin-allow-popups".into(),
285+
),
283286
(
284287
"Cross-Origin-Resource-Policy".into(),
285288
"same-origin".into(),
@@ -560,7 +563,10 @@ mod tests {
560563
fn includes_cross_origin_opener_policy() {
561564
let headers = create_default_headers("text/html");
562565
assert!(
563-
headers.contains(&("Cross-Origin-Opener-Policy".into(), "same-origin".into()))
566+
headers.contains(&(
567+
"Cross-Origin-Opener-Policy".into(),
568+
"same-origin-allow-popups".into(),
569+
))
564570
);
565571
}
566572

0 commit comments

Comments
 (0)