Enable and Fix Mypy Type Checking

[sergyDwhiz]

Mypy is configured in pyproject.toml and an improvement plan exists in MYPY_IMPROVEMENT_PLAN.md, but type checking is currently disabled in CI due to multiple type errors. This issue tracks the work needed to fix the existing errors and re-enable mypy in the CI pipeline.

Current Status

• Mypy configuration exists and is valid.
• CI integration is commented out.
• Approximately 45 type errors are reported when running mypy manually.

Common issue categories:

• Tests accessing attributes on possibly None values
• Missing type hints on function parameters
• Type inconsistencies in certain management commands
• Miscellaneous small annotation and narrowing issues

Proposed Approach

• Resolve the simpler errors (primarily in tests and management commands).
• Address the remaining type errors across the codebase.
• Lastly, re-enable mypy in CI, ensuring type checking becomes part of the standard workflow.

To view the current errors locally: run cd app && python3 -m mypy reviews --config-file=../pyproject.toml
This work should not affect runtime behavior; all changes will be confined to type hints and related adjustments.

[xenacode-art]

Hi @sergyDwhiz , great one there. I've actually been working on this for a while. Here's my progress:

• ✅ PR Feature/mypy incremental improvements #138 (merged) - Initial mypy error reduction
• 🔧 PR Fix mypy type errors in tests and views #152 (open) - Fixes 13 type errors in tests and views
• 🔧 PR Fix mypy Optional/None errors in autoreview tests #153 (open) - Fixes 9 Optional/None errors in autoreview tests

Together with the merged PR, these address most of the errors you mentioned (missing type hints, tests accessing
attributes on possibly-None values).

I'm planning to continue with the remaining errors and re-enable the mypy CI check once all errors are resolved.
Would you like to collaborate on different parts of the remaining work, or coordinate on the approach?

[sergyDwhiz]

Hi @xenacode-art, thanks for this so far.
But, could we have one PR which does the whole fix? Just so we don't loose out in reviewing multiple PRs.
Once that is done, would take a look and do the necessary improvements.

Thank you!