Navigation Link: show indicator for legacy links with id but no dynamic binding#78684
Conversation
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Closes #73305
This PR adds a "(Needs update)" status indicator to navigation link blocks that carry a legacy numeric
idattribute but have nokindbinding.Why?
Some older or manually edited navigation links can retain a numeric
idwithout akindattribute. Sincekindis required for the block’s dynamic entity binding, these links will not automatically update if the linked content changes or is removed. Currently, this state is silent and users receive no indication that the link is no longer properly bound.How?
Detects legacy unbound links with
Number.isInteger( id) && ! kindand adds aNeedsUpdateDisplayUI, following the existingInvalidDraftDisplaypattern, to show a "(Needs update)" indicator.Testing Instructions
kindandmetadatafields using the Code Editorkindis added to the block attributes and the indicator disappears..Screen.Recording.2026-05-26.at.6.23.55.PM.mov
Screenshots or screencast
Used the following block for testing after removing the
kindandmetadataattributes:Use of AI Tools