Merge pull request #877 from dknauss/codex/fail-closed-nonce

masteradhoc · web-flow · commit e5f74e08490a · 2026-06-29T21:30:44.000+02:00
Fail closed when CSPRNG is unavailable during nonce generation
diff --git a/class-two-factor-core.php b/class-two-factor-core.php
@@ -1304,7 +1304,7 @@ public static function create_login_nonce( $user_id ) {
 		try {
 			$login_nonce['key'] = bin2hex( random_bytes( 32 ) );
 		} catch ( Exception $ex ) {
-			$login_nonce['key'] = wp_hash( $user_id . wp_rand() . microtime(), 'nonce' );
+			return false;
 		}
 
 		// Store the nonce hashed to avoid leaking it via database access.

Original file line number	Diff line number	Diff line change
`@@ -1304,7 +1304,7 @@ public static function create_login_nonce( $user_id ) {`
`1304`	`1304`	`try {`
`1305`	`1305`	`$login_nonce['key'] = bin2hex( random_bytes( 32 ) );`
`1306`	`1306`	`} catch ( Exception $ex ) {`
`1307`		`- $login_nonce['key'] = wp_hash( $user_id . wp_rand() . microtime(), 'nonce' );`
	`1307`	`+ return false;`
`1308`	`1308`	`}`
`1309`	`1309`
`1310`	`1310`	`// Store the nonce hashed to avoid leaking it via database access.`