add test cases and count guard

Author: masteradhoc

CLI/class-two-factor-cli-command.php

@@ -543,6 +543,16 @@ public function backup_codes( $args, $assoc_args ) {
 		}
 
 		$count = (int) WP_CLI\Utils\get_flag_value( $assoc_args, 'count', Two_Factor_Backup_Codes::NUMBER_OF_CODES );
+		if ( $count < 1 ) {
+			WP_CLI::error(
+				sprintf(
+					/* translators: %d: provided count */
+					__( 'Invalid value for --count: %d. It must be 1 or greater.', 'two-factor' ),
+					$count
+				)
+			);
+		}
+
 		$codes = Two_Factor_Backup_Codes::get_instance()->generate_codes(
 			$user,
 			array(

tests/cli/class-two-factor-cli-command.php

@@ -655,6 +655,38 @@ public function test_backup_codes_generate_custom_count() {
 		$this->assertSame( 6, $printed );
 	}
 
+	/**
+	 * A count lower than 1 is rejected.
+	 *
+	 * @covers Two_Factor_CLI_Command::backup_codes
+	 */
+	public function test_backup_codes_generate_rejects_zero_count() {
+		$message = $this->assert_command_aborts(
+			function () {
+				$this->command->backup_codes( array( 'generate', 'cli_test_user' ), array( 'count' => 0 ) );
+			}
+		);
+
+		$this->assertStringContainsString( 'Invalid value for --count', $message );
+		$this->assertSame( 0, Two_Factor_Backup_Codes::codes_remaining_for_user( $this->user ) );
+	}
+
+	/**
+	 * Negative count values are rejected.
+	 *
+	 * @covers Two_Factor_CLI_Command::backup_codes
+	 */
+	public function test_backup_codes_generate_rejects_negative_count() {
+		$message = $this->assert_command_aborts(
+			function () {
+				$this->command->backup_codes( array( 'generate', 'cli_test_user' ), array( 'count' => -5 ) );
+			}
+		);
+
+		$this->assertStringContainsString( 'Invalid value for --count', $message );
+		$this->assertSame( 0, Two_Factor_Backup_Codes::codes_remaining_for_user( $this->user ) );
+	}
+
 	/**
 	 * Regenerating replaces the previous set of codes.
 	 *