improving test coverage for tecDIR_FULL error

Author: neti-soft-com

src/libxrpl/ledger/View.cpp

@@ -1047,7 +1047,7 @@ dirLink(
     auto const page =
         view.dirInsert(keylet::ownerDir(owner), object->key(), describeOwnerDir(owner));
     if (!page)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
     object->setFieldU64(node, *page);
     return tesSUCCESS;
 }
@@ -1580,13 +1580,13 @@ trustCreate(
         keylet::ownerDir(uLowAccountID), sleRippleState->key(), describeOwnerDir(uLowAccountID));
 
     if (!lowNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     auto highNode = view.dirInsert(
         keylet::ownerDir(uHighAccountID), sleRippleState->key(), describeOwnerDir(uHighAccountID));
 
     if (!highNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     bool const bSetDst = saLimit.getIssuer() == uDstAccountID;
     bool const bSetHigh = bSrcHigh ^ bSetDst;

src/libxrpl/tx/transactors/account/SetSignerList.cpp

@@ -323,7 +323,7 @@ SetSignerList::replaceSignerList()
                      << (page ? "success" : "failure");
 
     if (!page)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     signerList->setFieldU64(sfOwnerNode, *page);
 

src/libxrpl/tx/transactors/bridge/XChainBridge.cpp

@@ -1092,12 +1092,12 @@ applyCreateAccountAttestations(
         auto const page = psb.dirInsert(
             keylet::ownerDir(doorAccount), claimIDKeylet, describeOwnerDir(doorAccount));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*createdSleClaimID)[sfOwnerNode] = *page;
 
         auto const sleDoor = psb.peek(doorK);
         if (!sleDoor)
-            return tecINTERNAL;  // LCOV_EXCL_LINE
+            return tecINTERNAL;
 
         // Reserve was already checked
         adjustOwnerCount(psb, sleDoor, 1, j);
@@ -1968,7 +1968,7 @@ XChainCreateClaimID::doApply()
         auto const page = ctx_.view().dirInsert(
             keylet::ownerDir(account), claimIDKeylet, describeOwnerDir(account));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*sleClaimID)[sfOwnerNode] = *page;
     }
 

src/libxrpl/tx/transactors/check/CreateCheck.cpp

@@ -178,7 +178,7 @@ CreateCheck::doApply()
                          << ": " << (page ? "success" : "failure");
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         sleCheck->setFieldU64(sfDestinationNode, *page);
     }
@@ -191,7 +191,7 @@ CreateCheck::doApply()
                          << (page ? "success" : "failure");
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         sleCheck->setFieldU64(sfOwnerNode, *page);
     }

src/libxrpl/tx/transactors/delegate/DelegateSet.cpp

@@ -85,7 +85,7 @@ DelegateSet::doApply()
             keylet::ownerDir(account_), delegateKey, describeOwnerDir(account_));
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         (*sle)[sfOwnerNode] = *page;
         ctx_.view().insert(sle);

src/libxrpl/tx/transactors/nft/NFTokenUtils.cpp

@@ -924,7 +924,7 @@ tokenOfferCreateApply(
             view.dirInsert(keylet::ownerDir(acctID), offerID, describeOwnerDir(acctID));
 
         if (!ownerNode)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         bool const isSellOffer = txFlags & tfSellNFToken;
 
@@ -939,7 +939,7 @@ tokenOfferCreateApply(
             });
 
         if (!offerNode)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         std::uint32_t sleFlags = 0;
 

src/libxrpl/tx/transactors/oracle/SetOracle.cpp

@@ -282,7 +282,7 @@ SetOracle::doApply()
         auto page = ctx_.view().dirInsert(
             keylet::ownerDir(account_), sle->key(), describeOwnerDir(account_));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         (*sle)[sfOwnerNode] = *page;
 

src/libxrpl/tx/transactors/system/CreateTicket.cpp

@@ -100,7 +100,7 @@ CreateTicket::doApply()
                          << (page ? "success" : "failure");
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         sleTicket->setFieldU64(sfOwnerNode, *page);
     }

src/libxrpl/tx/transactors/token/MPTokenAuthorize.cpp

@@ -142,7 +142,7 @@ MPTokenAuthorize::createMPToken(
         view.dirInsert(keylet::ownerDir(account), mptokenKey, describeOwnerDir(account));
 
     if (!ownerNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     auto mptoken = std::make_shared<SLE>(mptokenKey);
     (*mptoken)[sfAccount] = account;

src/libxrpl/tx/transactors/token/MPTokenIssuanceCreate.cpp

@@ -94,7 +94,7 @@ MPTokenIssuanceCreate::create(ApplyView& view, beast::Journal journal, MPTCreate
             keylet::ownerDir(args.account), mptIssuanceKeylet, describeOwnerDir(args.account));
 
         if (!ownerNode)
-            return Unexpected(tecDIR_FULL);  // LCOV_EXCL_LINE
+            return Unexpected(tecDIR_FULL);
 
         auto mptIssuance = std::make_shared<SLE>(mptIssuanceKeylet);
         (*mptIssuance)[sfFlags] = args.flags & ~tfUniversal;