improving tests coverage for tecDIR_FULL error

Author: neti-soft-com

src/libxrpl/ledger/View.cpp

@@ -301,7 +301,7 @@ dirLink(
     auto const page =
         view.dirInsert(keylet::ownerDir(owner), object->key(), describeOwnerDir(owner));
     if (!page)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
     object->setFieldU64(node, *page);
     return tesSUCCESS;
 }

src/libxrpl/ledger/helpers/MPTokenHelpers.cpp

@@ -765,7 +765,7 @@ createMPToken(
         view.dirInsert(keylet::ownerDir(account), mptokenKey, describeOwnerDir(account));
 
     if (!ownerNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     auto mptoken = std::make_shared<SLE>(mptokenKey);
     (*mptoken)[sfAccount] = account;

src/libxrpl/ledger/helpers/NFTokenHelpers.cpp

@@ -959,7 +959,7 @@ tokenOfferCreateApply(
             view.dirInsert(keylet::ownerDir(acctID), offerID, describeOwnerDir(acctID));
 
         if (!ownerNode)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         bool const isSellOffer = (txFlags & tfSellNFToken) != 0u;
 
@@ -974,7 +974,7 @@ tokenOfferCreateApply(
             });
 
         if (!offerNode)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         std::uint32_t sleFlags = 0;
 

src/libxrpl/ledger/helpers/RippleStateHelpers.cpp

@@ -199,13 +199,13 @@ trustCreate(
         keylet::ownerDir(uLowAccountID), sleRippleState->key(), describeOwnerDir(uLowAccountID));
 
     if (!lowNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     auto highNode = view.dirInsert(
         keylet::ownerDir(uHighAccountID), sleRippleState->key(), describeOwnerDir(uHighAccountID));
 
     if (!highNode)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     bool const bSetDst = saLimit.getIssuer() == uDstAccountID;
     bool const bSetHigh = bSrcHigh ^ bSetDst;

src/libxrpl/tx/transactors/account/SignerListSet.cpp

@@ -323,7 +323,7 @@ SignerListSet::replaceSignerList()
                      << (page ? "success" : "failure");
 
     if (!page)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     signerList->setFieldU64(sfOwnerNode, *page);
 

src/libxrpl/tx/transactors/bridge/XChainBridge.cpp

@@ -1109,12 +1109,12 @@ applyCreateAccountAttestations(
         auto const page = psb.dirInsert(
             keylet::ownerDir(doorAccount), claimIDKeylet, describeOwnerDir(doorAccount));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*createdSleClaimID)[sfOwnerNode] = *page;
 
         auto const sleDoor = psb.peek(doorK);
         if (!sleDoor)
-            return tecINTERNAL;  // LCOV_EXCL_LINE
+            return tecINTERNAL;
 
         // Reserve was already checked
         adjustOwnerCount(psb, sleDoor, 1, j);
@@ -1456,7 +1456,7 @@ XChainCreateBridge::doApply()
         auto const page = ctx_.view().dirInsert(
             keylet::ownerDir(account), bridgeKeylet, describeOwnerDir(account));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*sleBridge)[sfOwnerNode] = *page;
     }
 
@@ -2016,7 +2016,7 @@ XChainCreateClaimID::doApply()
         auto const page = ctx_.view().dirInsert(
             keylet::ownerDir(account), claimIDKeylet, describeOwnerDir(account));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*sleClaimID)[sfOwnerNode] = *page;
     }
 

src/libxrpl/tx/transactors/check/CheckCreate.cpp

@@ -206,7 +206,7 @@ CheckCreate::doApply()
                          << ": " << (page ? "success" : "failure");
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         sleCheck->setFieldU64(sfDestinationNode, *page);
     }
@@ -219,7 +219,7 @@ CheckCreate::doApply()
                          << (page ? "success" : "failure");
 
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
 
         sleCheck->setFieldU64(sfOwnerNode, *page);
     }

src/libxrpl/tx/transactors/delegate/DelegateSet.cpp

@@ -97,7 +97,7 @@ DelegateSet::doApply()
         ctx_.view().dirInsert(keylet::ownerDir(account_), delegateKey, describeOwnerDir(account_));
 
     if (!page)
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
 
     (*sle)[sfOwnerNode] = *page;
     ctx_.view().insert(sle);

src/libxrpl/tx/transactors/dex/OfferCreate.cpp

@@ -522,7 +522,7 @@ OfferCreate::applyHybrid(
     if (!bookNode)
     {
         JLOG(j_.debug()) << "final result: failed to add hybrid offer to open book";
-        return tecDIR_FULL;  // LCOV_EXCL_LINE
+        return tecDIR_FULL;
     }
 
     STArray bookArr(sfAdditionalBooks, 1);
@@ -799,10 +799,8 @@ OfferCreate::applyGuts(Sandbox& sb, Sandbox& sbCancel)
 
     if (!ownerNode)
     {
-        // LCOV_EXCL_START
         JLOG(j_.debug()) << "final result: failed to add offer to owner's directory";
         return {tecDIR_FULL, true};
-        // LCOV_EXCL_STOP
     }
 
     // Update owner count.
@@ -853,10 +851,8 @@ OfferCreate::applyGuts(Sandbox& sb, Sandbox& sbCancel)
 
     if (!bookNode)
     {
-        // LCOV_EXCL_START
         JLOG(j_.debug()) << "final result: failed to add offer to book";
         return {tecDIR_FULL, true};
-        // LCOV_EXCL_STOP
     }
 
     auto sleOffer = std::make_shared<SLE>(offer_index);

src/libxrpl/tx/transactors/did/DIDSet.cpp

@@ -72,7 +72,7 @@ addSLE(ApplyContext& ctx, std::shared_ptr<SLE> const& sle, AccountID const& owne
         auto page =
             ctx.view().dirInsert(keylet::ownerDir(owner), sle->key(), describeOwnerDir(owner));
         if (!page)
-            return tecDIR_FULL;  // LCOV_EXCL_LINE
+            return tecDIR_FULL;
         (*sle)[sfOwnerNode] = *page;
     }
     adjustOwnerCount(ctx.view(), sleAccount, 1, ctx.journal);