Skip to content

Commit d876d33

Browse files
committed
update mda with fix for numeric floating error
1 parent 1f0a990 commit d876d33

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • feature_importance/scripts

feature_importance/scripts/mda.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ def MDA(rf, X, y, type = 'oob', n_trials = 10, metric = 'accuracy'):
2929
permute_std += to_add ** 2
3030
permute_score /= n_trials
3131
permute_std /= n_trials
32-
permute_std = (permute_std - permute_score ** 2) ** .5 / n_trials ** .5
32+
permute_var = max(permute_std - permute_score ** 2, 0.0)
33+
permute_std = permute_var ** .5 / n_trials ** .5
3334
fi_mean[f] = best_score - permute_score
3435
fi_std[f] = permute_std
3536
return fi_mean, fi_std

0 commit comments

Comments
 (0)