fix: stop logging submitted form values

Files changed:
- record/log/logger.py: Stop serializing submitted POST values at the shared request logger.
- record/tests.py: Cover request-format redaction.
- app/test/test_log.py: Cover local and WeChat exception-path redaction.

Author: KeZhao783

app/test/test_log.py

@@ -0,0 +1,37 @@
+import logging
+from unittest.mock import patch
+
+from django.contrib.auth.models import AnonymousUser
+from django.test import RequestFactory, SimpleTestCase
+
+from app.log import ProfileLogger
+
+
+class ProfileLoggerRedactionTestCase(SimpleTestCase):
+    def test_secure_view_omits_post_values_from_log_and_wechat(self):
+        secrets = ["password-v13", "token-v13", "identity-v13"]
+        request = RequestFactory().post(
+            "/failing-view/",
+            {"password": secrets[0], "token": secrets[1], "identity": secrets[2]},
+        )
+        request.user = AnonymousUser()
+        logger = ProfileLogger("v13-test")
+        logger.setLevel(logging.DEBUG)
+        logger.set_debug_mode(False)
+
+        @logger.secure_view()
+        def failing_view(request):
+            raise RuntimeError("diagnostic-v13")
+
+        with patch.object(logger, "_send_wechat") as send_wechat:
+            with self.assertLogs(logger, level="ERROR") as captured:
+                response = failing_view(request)
+
+        local_message = "\n".join(captured.output)
+        wechat_message = send_wechat.call_args.args[0]
+        self.assertEqual(response.status_code, 302)
+        for message in (local_message, wechat_message):
+            self.assertIn("URL: /failing-view/", message)
+            self.assertIn("Method: POST", message)
+            for value in secrets:
+                self.assertNotIn(value, message)

record/log/logger.py

@@ -18,7 +18,6 @@
 """
 
 import os
-import json
 import logging
 from typing import Callable, Any, cast, ParamSpec, Concatenate, TypeVar
 
@@ -111,11 +110,6 @@ def _request_msgs(cls, request: HttpRequest) -> list[str]:
             msgs.append('User: ' + request.user.__str__())  # Traceable Call
         if request.method is not None:
             msgs.append('Method: ' + request.method)
-            if request.method.lower() == 'POST':
-                try:
-                    msgs.append('Data: ' + json.dumps(request.POST.dict()))
-                except:
-                    msgs.append('Failed to jsonify post data.')
         return msgs
 
     def on_exception(self, message: str = '', *,

record/tests.py

@@ -0,0 +1,22 @@
+from django.contrib.auth.models import AnonymousUser
+from django.test import RequestFactory, SimpleTestCase
+
+from record.log.logger import Logger
+
+
+class RequestLoggingTestCase(SimpleTestCase):
+    def test_format_request_omits_post_values(self):
+        secrets = ["pw-v13-secret", "token-v13-secret", "code-v13-secret"]
+        request = RequestFactory().post(
+            "/submit-sensitive/?source=test",
+            {"password": secrets[0], "token": secrets[1], "code": secrets[2]},
+        )
+        request.user = AnonymousUser()
+
+        message = Logger.format_request(request)
+
+        self.assertIn("URL: /submit-sensitive/?source=test", message)
+        self.assertIn("Method: POST", message)
+        self.assertNotIn("Data:", message)
+        for value in secrets:
+            self.assertNotIn(value, message)