Skip to content

Commit 3d9c922

Browse files
committed
fix(review-feedback-1256): address latest review comments
1 parent bcb0648 commit 3d9c922

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

scripts/verify-desktop-updater-artifacts.ps1

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ if (-not $DistDir) {
2525
$DistDir = Join-Path $PSScriptRoot '..\apps\dsa-desktop\dist'
2626
}
2727

28-
$distDirPath = (Resolve-Path $DistDir -ErrorAction SilentlyContinue)?.Path
28+
$resolvedDistDir = Resolve-Path $DistDir -ErrorAction SilentlyContinue
29+
$distDirPath = ''
30+
if ($resolvedDistDir) {
31+
$distDirPath = $resolvedDistDir.Path
32+
}
2933
if (-not $distDirPath) {
3034
Write-Host "[check] dist directory not found: $DistDir"
3135
Write-Host "[check] if build is not executed on this host, skip validation."
@@ -79,15 +83,21 @@ $releaseAssetsDirPath = ''
7983
$releaseAssetsDirWasExplicit = -not [string]::IsNullOrWhiteSpace($ReleaseAssetsDir)
8084

8185
if ($releaseAssetsDirWasExplicit) {
82-
$releaseAssetsDirPath = (Resolve-Path $ReleaseAssetsDir -ErrorAction SilentlyContinue)?.Path
86+
$resolvedReleaseAssetsDir = Resolve-Path $ReleaseAssetsDir -ErrorAction SilentlyContinue
87+
if ($resolvedReleaseAssetsDir) {
88+
$releaseAssetsDirPath = $resolvedReleaseAssetsDir.Path
89+
}
8390
if (-not $releaseAssetsDirPath) {
8491
throw "Release assets directory not found: $ReleaseAssetsDir"
8592
}
8693
} elseif ((Split-Path -Path $distDirPath -Leaf) -eq 'release-assets') {
8794
$releaseAssetsDirPath = $distDirPath
8895
} else {
8996
$defaultReleaseAssetsDir = Join-Path $distDirPath 'release-assets'
90-
$releaseAssetsDirPath = (Resolve-Path $defaultReleaseAssetsDir -ErrorAction SilentlyContinue)?.Path
97+
$resolvedReleaseAssetsDir = Resolve-Path $defaultReleaseAssetsDir -ErrorAction SilentlyContinue
98+
if ($resolvedReleaseAssetsDir) {
99+
$releaseAssetsDirPath = $resolvedReleaseAssetsDir.Path
100+
}
91101
}
92102

93103
if ($releaseAssetsDirPath) {

0 commit comments

Comments
 (0)