fix(review-feedback-1256): address latest review comments

Author: ZhuLinsen

scripts/build-desktop-macos.sh

@@ -16,9 +16,49 @@ if [[ ! -d "${ROOT_DIR}/dist/backend/stock_analysis" ]]; then
 fi
 
 pushd "${ROOT_DIR}/apps/dsa-desktop" >/dev/null
-if [[ ! -d node_modules ]]; then
+
+package_lock_hash() {
+  if command -v shasum >/dev/null 2>&1; then
+    shasum -a 256 package-lock.json | awk '{print $1}'
+  elif command -v sha256sum >/dev/null 2>&1; then
+    sha256sum package-lock.json | awk '{print $1}'
+  else
+    echo "No SHA-256 checksum tool found. Install shasum or sha256sum." >&2
+    exit 1
+  fi
+}
+
+install_desktop_dependencies() {
+  local reason="$1"
+
+  echo "Installing desktop dependencies (${reason})..."
   npm install
-fi
+  mkdir -p node_modules
+  package_lock_hash > node_modules/.dsa-package-lock.sha256
+}
+
+ensure_desktop_dependencies() {
+  local marker="node_modules/.dsa-package-lock.sha256"
+  local reason=""
+
+  if [[ ! -d node_modules ]]; then
+    reason="node_modules missing"
+  elif [[ ! -f "${marker}" ]]; then
+    reason="package-lock marker missing"
+  elif [[ "$(tr -d '[:space:]' < "${marker}")" != "$(package_lock_hash)" ]]; then
+    reason="package-lock.json changed"
+  elif [[ ! -d node_modules/electron-updater ]]; then
+    reason="electron-updater missing"
+  fi
+
+  if [[ -n "${reason}" ]]; then
+    install_desktop_dependencies "${reason}"
+  else
+    echo "Desktop dependencies are up to date."
+  fi
+}
+
+ensure_desktop_dependencies
 
 if compgen -G "dist/mac*" >/dev/null; then
   echo "Cleaning dist/mac*..."

scripts/build-desktop.ps1

@@ -29,12 +29,53 @@ if (!(Test-Path $backendArtifact)) {
   throw "Backend artifact not found: $backendArtifact. Run scripts\build-backend.ps1 first."
 }
 
-Write-Host 'Building Electron desktop app...'
-Push-Location (Join-Path $repoRoot 'apps\dsa-desktop')
-if (!(Test-Path 'node_modules')) {
+function Get-PackageLockHash {
+  return (Get-FileHash -Path 'package-lock.json' -Algorithm SHA256).Hash
+}
+
+function Install-DesktopDependencies {
+  param(
+    [string]$Reason,
+    [switch]$Clean
+  )
+
+  Write-Host "Installing desktop dependencies ($Reason)..."
+  if ($Clean -and (Test-Path 'node_modules')) {
+    Remove-Item -Recurse -Force 'node_modules'
+  }
   npm install
+  if ($LASTEXITCODE -ne 0) {
+    throw 'Desktop dependency installation failed.'
+  }
+  New-Item -ItemType Directory -Force -Path 'node_modules' | Out-Null
+  Set-Content -Path 'node_modules\.dsa-package-lock.sha256' -Value (Get-PackageLockHash) -Encoding ascii
+}
+
+function Ensure-DesktopDependencies {
+  $lockHashMarker = 'node_modules\.dsa-package-lock.sha256'
+  $installReason = $null
+
+  if (!(Test-Path 'node_modules')) {
+    $installReason = 'node_modules missing'
+  } elseif (!(Test-Path $lockHashMarker)) {
+    $installReason = 'package-lock marker missing'
+  } elseif ((Get-Content -Path $lockHashMarker -Raw).Trim() -ne (Get-PackageLockHash)) {
+    $installReason = 'package-lock.json changed'
+  } elseif (!(Test-Path 'node_modules\electron-updater')) {
+    $installReason = 'electron-updater missing'
+  }
+
+  if ($null -ne $installReason) {
+    Install-DesktopDependencies -Reason $installReason
+  } else {
+    Write-Host 'Desktop dependencies are up to date.'
+  }
 }
 
+Write-Host 'Building Electron desktop app...'
+Push-Location (Join-Path $repoRoot 'apps\dsa-desktop')
+Ensure-DesktopDependencies
+
 Write-Host 'Stopping running app (if any)...'
 Get-Process -Name "Daily Stock Analysis" -ErrorAction SilentlyContinue | Stop-Process -Force
 Get-Process -Name "stock_analysis" -ErrorAction SilentlyContinue | Stop-Process -Force
@@ -47,10 +88,7 @@ if (Test-Path 'dist\win-unpacked') {
 $appBuilderPath = 'node_modules\app-builder-bin\win\x64\app-builder.exe'
 if (!(Test-Path $appBuilderPath)) {
   Write-Host 'app-builder.exe missing, reinstalling dependencies...'
-  if (Test-Path 'node_modules') {
-    Remove-Item -Recurse -Force 'node_modules'
-  }
-  npm install
+  Install-DesktopDependencies -Reason 'app-builder.exe missing' -Clean
 }
 
 npx electron-builder --win nsis