fix(review-feedback-1241): address latest review comments

Author: ZhuLinsen

src/market_analyzer.py

@@ -771,9 +771,9 @@ def _format_news_source_cell(cls, item: Any) -> str:
         date_text = cls._compact_news_text(cls._get_news_field(item, "published_date"), limit=24)
         url = cls._compact_news_text(cls._get_news_field(item, "url"), limit=0)
         label_parts = [part for part in (source, date_text) if part]
-        label = " / ".join(label_parts) or "source"
+        label = " / ".join(label_parts)
         if url:
-            return f"[{label}]({url})"
+            return f"[{label or 'URL'}]({url})"
         return label
 
     @staticmethod
@@ -878,7 +878,7 @@ def _build_review_prompt(self, overview: MarketOverview, news: List) -> str:
             snippet = self._compact_news_text(self._get_news_field(n, "snippet"), limit=220)
             source = self._compact_news_text(self._get_news_field(n, "source"), limit=60)
             published_date = self._compact_news_text(self._get_news_field(n, "published_date"), limit=30)
-            url = self._get_news_field(n, "url")
+            url = self._compact_news_text(self._get_news_field(n, "url"), limit=180)
             meta_parts = [part for part in (source, published_date) if part]
             meta = f" ({' / '.join(meta_parts)})" if meta_parts else ""
             url_line = f"\n   URL: {url}" if url else ""

tests/test_market_analyzer_generate_text.py

@@ -866,6 +866,46 @@ def test_news_block_labels_snippets_and_preserves_source_url(self):
         assert "成交额放大" in result
         assert "[东方财富 / 2026-05-06](https://example.com/news/1)" in result
 
+    def test_news_block_uses_dash_when_source_metadata_missing(self):
+        from src.market_analyzer import MarketAnalyzer
+
+        ma = MarketAnalyzer.__new__(MarketAnalyzer)
+        ma.config = SimpleNamespace(report_language="zh")
+        ma.region = "cn"
+
+        result = ma._build_news_block([
+            {
+                "title": "政策利好带动板块活跃",
+                "snippet": "相关主题成交放大",
+            }
+        ])
+
+        assert "| 1 | 政策利好带动板块活跃 | 相关主题成交放大 | - |" in result
+        assert "| 1 | 政策利好带动板块活跃 | 相关主题成交放大 | source |" not in result
+
+    def test_review_prompt_caps_news_url_context(self):
+        from src.market_analyzer import MarketOverview
+
+        ma = self._make_market_analyzer_with_mock_generate_text(return_value="review")
+        long_url = "https://example.com/redirect?" + "utm_campaign=" + ("x" * 420)
+
+        prompt = ma._build_review_prompt(
+            MarketOverview(date="2026-05-06"),
+            [
+                {
+                    "title": "A股收评：指数放量反弹",
+                    "snippet": "科技成长方向领涨",
+                    "source": "测试来源",
+                    "published_date": "2026-05-06",
+                    "url": long_url,
+                }
+            ],
+        )
+
+        assert long_url not in prompt
+        assert "URL: https://example.com/redirect?" in prompt
+        assert ("x" * 220) not in prompt
+
     def test_market_light_snapshot_marks_defensive_market_red(self):
         from src.market_analyzer import MarketIndex, MarketOverview