Skip to content

Commit fe0ef72

Browse files
committed
fix(review-feedback-1294): address latest review comments
1 parent 995e96a commit fe0ef72

5 files changed

Lines changed: 9 additions & 5 deletions

File tree

apps/dsa-web/src/utils/systemConfigI18n.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ const fieldDescriptionMap: Record<string, string> = {
142142
GOTIFY_TOKEN: 'Gotify application token,系统通过 X-Gotify-Key Header 发送,不会放进 URL。',
143143
PUSHPLUS_TOKEN: 'PushPlus 推送令牌。',
144144
REPORT_SUMMARY_ONLY: '仅推送分析结果摘要,不包含个股详情。多股时适合快速浏览。',
145-
REPORT_SHOW_LLM_MODEL: '在通知报告底部显示本次分析使用的 LLM 模型名称;关闭后隐藏运行时模型信息。',
145+
REPORT_SHOW_LLM_MODEL: '在通知报告底部显示本次分析使用的 LLM 模型名称;关闭后隐藏运行时模型信息。仅影响展示,不会影响 provider/model/Base URL、运行时模型保存、迁移或清理。',
146146
MAX_WORKERS: '异步任务队列最大并发数。配置保存后,队列空闲时会自动应用;繁忙时延后生效。',
147147
SCHEDULE_TIME: '每日定时任务执行时间,格式为 HH:MM。',
148148
HTTP_PROXY: '网络代理地址,可留空。',

docs/full-guide.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ daily_stock_analysis/
116116
| `REPORT_TYPE` | 报告类型:`simple`(精简)、`full`(完整)、`brief`(3-5句概括),Docker环境推荐设为 `full` | 可选 |
117117
| `REPORT_LANGUAGE` | 报告输出语言:`zh`(默认中文) / `en`(英文);会同步影响 Prompt、模板、通知 fallback 与 Web 报告页固定文案。仓库自带 `daily_analysis.yml` 已显式映射该变量,直接在 Actions Secrets/Variables 中配置即可生效 | 可选 |
118118
| `REPORT_SUMMARY_ONLY` | 仅分析结果摘要:设为 `true` 时只推送汇总,不含个股详情;多股时适合快速浏览(默认 false,Issue #262| 可选 |
119-
| `REPORT_SHOW_LLM_MODEL` | 通知报告底部是否显示本次分析使用的 LLM 模型名称,默认 `true`;设为 `false` 可隐藏运行时模型信息 | 可选 |
119+
| `REPORT_SHOW_LLM_MODEL` | 通知报告底部是否显示本次分析使用的 LLM 模型名称,默认 `true`;设为 `false` 可隐藏运行时模型信息。该变量仅调整展示,不影响 provider/model/Base URL、LiteLLM 路由或运行时模型保存/迁移/清理语义。 | 可选 |
120120
| `REPORT_TEMPLATES_DIR` | Jinja2 模板目录(相对项目根,默认 `templates`| 可选 |
121121
| `REPORT_RENDERER_ENABLED` | 启用 Jinja2 模板渲染(默认 `false`,保证零回归) | 可选 |
122122
| `REPORT_INTEGRITY_ENABLED` | 启用报告完整性校验,缺失必填字段时重试或占位补全(默认 `true`| 可选 |
@@ -138,6 +138,8 @@ daily_stock_analysis/
138138
| `MD2IMG_ENGINE` | 转图引擎:`wkhtmltoimage`(默认,需 wkhtmltopdf)或 `markdown-to-file`(emoji 更好,需 `npm i -g markdown-to-file`| 可选 |
139139
| `PREFETCH_REALTIME_QUOTES` | 设为 `false` 可禁用实时行情预取,避免 efinance/akshare_em 全市场拉取(默认 true) | 可选 |
140140

141+
> 兼容性说明:`REPORT_SHOW_LLM_MODEL` 维持默认 `true` 的原始展示语义,关闭时只影响底部模型文案输出。该配置不会变更 provider/model/Base URL、LiteLLM 路由、模型保存、迁移或清理语义;回退方式为恢复或删除该变量,并设为 `true`
142+
141143
#### 其他配置
142144

143145
| Secret 名称 | 说明 | 必填 |

docs/full-guide_EN.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ Go to your forked repo → `Settings` → `Secrets and variables` → `Actions`
116116
| `SINGLE_STOCK_NOTIFY` | Single stock push mode: set to `true` to push immediately after each stock analysis | Optional |
117117
| `REPORT_TYPE` | Report type: `simple` (concise), `full` (complete), `brief` (3-5 sentences), Docker recommended: `full` | Optional |
118118
| `REPORT_LANGUAGE` | Report output language: `zh` (default Chinese) / `en` (English); also updates prompt instructions, templates, notification fallbacks, and fixed copy in the Web report view. The bundled `daily_analysis.yml` already maps this variable, so setting it in Actions Secrets/Variables works out of the box | Optional |
119-
| `REPORT_SHOW_LLM_MODEL` | Whether notification report footers show the LLM model used for analysis. Defaults to `true`; set to `false` to hide runtime model metadata | Optional |
119+
| `REPORT_SHOW_LLM_MODEL` | Whether notification report footers show the LLM model used for analysis. Defaults to `true`; set to `false` to hide runtime model metadata. This switch only affects presentation and does not change provider/model/Base URL, LiteLLM routing, or runtime model save/migration/cleanup behavior. | Optional |
120120
| `REPORT_TEMPLATES_DIR` | Jinja2 template directory (relative to project root, default `templates`) | Optional |
121121
| `REPORT_RENDERER_ENABLED` | Enable Jinja2 template rendering (default `false`, zero regression) | Optional |
122122
| `REPORT_INTEGRITY_ENABLED` | Enable report integrity checks, retry or placeholder on missing fields (default `true`) | Optional |
@@ -133,6 +133,8 @@ Go to your forked repo → `Settings` → `Secrets and variables` → `Actions`
133133
| `NOTIFICATION_MIN_SEVERITY` | Minimum severity: `info`, `warning`, `error`, `critical`. Empty keeps current behavior | Optional |
134134
| `NOTIFICATION_DAILY_DIGEST_ENABLED` | Reserved daily digest flag. The current implementation does not send or persist digests | Optional |
135135

136+
> Compatibility note: `REPORT_SHOW_LLM_MODEL` keeps the previous default-visible behavior (`true`) and only changes report footer rendering. It does not alter provider/model/Base URL, LiteLLM routing, or runtime model persistence/migration/cleanup semantics. Rollback is to remove the variable or set it back to `true`.
137+
136138
#### Other Configuration
137139

138140
| Secret Name | Description | Required |

docs/notifications.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
- Advanced key:只影响认证、安全、格式、线程、群组、证书校验或展示行为,不能单独启用渠道。
3030
- P3 的 `NOTIFICATION_*_CHANNELS` 属于 Advanced key:只收窄已启用渠道,不会单独启用渠道。
3131
- P4 的 `NOTIFICATION_DEDUP_TTL_SECONDS``NOTIFICATION_COOLDOWN_SECONDS``NOTIFICATION_QUIET_HOURS``NOTIFICATION_TIMEZONE``NOTIFICATION_MIN_SEVERITY``NOTIFICATION_DAILY_DIGEST_ENABLED` 属于 Advanced key:只影响已启用静态渠道的发送策略,不会单独启用渠道。
32-
- `REPORT_SHOW_LLM_MODEL` 是报告展示开关:默认 `true` 时在通知报告底部显示本次分析使用的 LLM 模型,设为 `false` 时隐藏。
32+
- `REPORT_SHOW_LLM_MODEL` 是报告展示开关:默认 `true` 时在通知报告底部显示本次分析使用的 LLM 模型,设为 `false` 时隐藏。该参数仅影响报告渲染,不会更改运行时的 provider/model/Base URL、LiteLLM 路由、模型保存、迁移或清理逻辑;回退方式为改回 `true` 或删除该变量。
3333
- `WEBHOOK_VERIFY_SSL` 是读取该配置的 webhook-style HTTPS 通知请求共用的证书校验开关。
3434
- WebPush、Apprise、更细粒度路由、跨进程降噪和真实每日摘要暂不进入运行时实现;相关配置如未来引入,应先更新本文档、`.env.example`、Web 元数据与回归测试。
3535
- Bark 保持 custom webhook 基线,不新增 `BARK_*` 一等配置。

src/core/config_registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -957,7 +957,7 @@
957957
},
958958
"REPORT_SHOW_LLM_MODEL": {
959959
"title": "Show LLM Model in Reports",
960-
"description": "Show the LLM model name in notification report footers. Disable to hide runtime model metadata.",
960+
"description": "Show the LLM model name in notification report footers. Disable to hide runtime model metadata. This option only affects report rendering and does not change runtime provider/model/Base URL/LiteLLM routing, migration, persistence, or cleanup behavior.",
961961
"category": "notification",
962962
"data_type": "boolean",
963963
"ui_control": "switch",

0 commit comments

Comments
 (0)