fix(review-feedback-997): address latest review comments

Author: ZhuLinsen

data_provider/base.py

@@ -680,6 +680,14 @@ def _try_scalar_isna(value: Any, context: str) -> Optional[bool]:
         try:
             isna_result = pd.isna(value)
         except (TypeError, ValueError) as exc:
+            if hasattr(value, "__array__"):
+                logger.debug(
+                    "[%s] pd.isna failed for array-like object; re-raise: value_type=%s error_type=%s",
+                    context,
+                    type(value).__name__,
+                    type(exc).__name__,
+                )
+                raise
             logger.debug(
                 "[%s] pd.isna fallback: value_type=%s error_type=%s",
                 context,
@@ -1813,7 +1821,7 @@ def _has_meaningful_payload(payload: Any) -> bool:
                 return False
             return any(
                 DataFetcherManager._has_meaningful_payload(v)
-                for v in payload.to_numpy().reshape(-1).tolist()
+                for v in payload.to_numpy().flat
             )
         if isinstance(payload, (pd.Series, pd.Index)):
             return any(DataFetcherManager._has_meaningful_payload(v) for v in payload.tolist())
@@ -1823,7 +1831,7 @@ def _has_meaningful_payload(payload: Any) -> bool:
             else:
                 return any(
                     DataFetcherManager._has_meaningful_payload(v)
-                    for v in payload.reshape(-1).tolist()
+                    for v in payload.flat
                 )
         if isinstance(payload, (list, tuple, set)):
             return any(DataFetcherManager._has_meaningful_payload(v) for v in payload)

tests/test_fundamental_context.py

@@ -491,6 +491,17 @@ def test_missing_value_helpers_log_expected_pd_isna_fallback(self) -> None:
         self.assertIn("[board_value] pd.isna fallback", joined_logs)
         self.assertIn("[fundamental_payload] pd.isna fallback", joined_logs)
 
+    def test_missing_value_helpers_propagate_array_protocol_pd_isna_errors(self) -> None:
+        class _ArrayProtocolErrorPayload:
+            def __array__(self):
+                raise ValueError("boom")
+
+        payload = _ArrayProtocolErrorPayload()
+        with self.assertRaises(ValueError):
+            DataFetcherManager._is_missing_board_value(payload)
+        with self.assertRaises(ValueError):
+            DataFetcherManager._has_meaningful_payload(payload)
+
     def test_missing_value_helpers_propagate_unexpected_pd_isna_errors(self) -> None:
         sentinel = object()
         with patch("data_provider.base.pd.isna", side_effect=RuntimeError("boom")):