Skip to content

Commit 32c62f3

Browse files
committed
clean up
1 parent b774dbb commit 32c62f3

2 files changed

Lines changed: 10 additions & 20 deletions

File tree

.github/workflows/_checks-playwright.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ on:
3030
description: "Node.js version to use"
3131
type: string
3232
default: "22"
33+
pnpm_version:
34+
description: "pnpm version to use"
35+
type: string
36+
default: "latest"
3337
use_env_local:
3438
description: "Whether to use the environment local file provided in secrets"
3539
type: boolean
@@ -157,7 +161,7 @@ jobs:
157161
with:
158162
node_version: ${{ inputs.node_version }}
159163
package_manager: "pnpm"
160-
package_manager_version: "10"
164+
pnpm_version: ${{ inputs.pnpm_version }}
161165
autoinit_env: ${{ inputs.autoinit_env }}
162166

163167
- name: Run build

.github/workflows/_checks-ts.yaml

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -30,77 +30,62 @@ on:
3030
default: "test:coverage"
3131
node_version:
3232
description: "Node.js version to use"
33-
required: false
3433
type: string
3534
default: "22"
3635
package_manager:
3736
description: "Package manager to use (bun or pnpm)"
38-
required: false
3937
type: string
4038
default: "bun"
4139
bun_version:
42-
description: "Bun version"
43-
required: false
40+
description: "Bun version to use"
4441
type: string
4542
default: "1.2.13"
4643
pnpm_version:
47-
description: "PNPM version"
48-
required: false
44+
description: "pnpm version to use"
4945
type: string
50-
default: "10.4.1"
46+
default: "latest"
5147
base_image:
5248
description: "Docker image to use for base image"
53-
required: false
5449
type: string
5550
default: "ubuntu:24.04"
5651
test_command:
5752
description: "Test command to run from package.json"
58-
required: false
5953
type: string
6054
default: "test"
6155
lint_command:
6256
description: "Lint command to run from package.json"
63-
required: false
6457
type: string
6558
default: "lint"
6659
format_command:
6760
description: "Format command to run from package.json"
68-
required: false
6961
type: string
7062
default: "format:check"
7163
checkout_submodules:
7264
description: "Checkout submodules"
73-
required: false
7465
type: boolean
7566
default: true
7667
github_app_auth:
7768
description: "Use GitHub App Token"
78-
required: false
7969
type: boolean
8070
default: false
8171
github_app_repos:
8272
description: "Additional repositories to access (one per line)"
83-
required: false
8473
type: string
8574
default: ""
8675
codecov_flags:
8776
description: "Flags to pass to Codecov"
88-
required: false
8977
type: string
9078
default: ""
9179
autoinit_env:
9280
description: "Automatically run env:init:ci script after installing dependencies"
93-
required: false
9481
type: boolean
9582
default: false
9683
gcp_wif_provider:
9784
description: "GCP Workload Identity Provider (required if autoinit_env is true)"
98-
required: false
9985
type: string
10086
default: ""
10187
gcp_project_id:
10288
description: "GCP Project ID (required if autoinit_env is true)"
103-
required: false
10489
type: string
10590
default: ""
10691
secrets:
@@ -156,7 +141,8 @@ jobs:
156141
with:
157142
node_version: ${{ inputs.node_version }}
158143
package_manager: ${{ inputs.package_manager }}
159-
package_manager_version: ${{ inputs.package_manager == 'bun' && inputs.bun_version || inputs.pnpm_version }}
144+
bun_version: ${{ inputs.bun_version }}
145+
pnpm_version: ${{ inputs.pnpm_version }}
160146
autoinit_env: ${{ inputs.autoinit_env }}
161147

162148
- name: Check format

0 commit comments

Comments
 (0)