TypeError: this.onerror is not a function onconnect/<@https://***.***.pl/zm/js/video-rtc.js:308:56

[atlochowski]

Describe Your Environment

• Version of ZoneMinder [1.39.18]

• Debian 13

• Browser name and version Firefox

Describe the bug
TypeError: this.onerror is not a function
TypeError: this.onerror is not a function onconnect/<@https:/***********/zm/js/video-rtc.js:308:56

Line 308:
this.ws.addEventListener('error', (ev) => this.onerror(ev));

So object RTCVideo didnt' have defined function onerror()

To Reproduce

1. If you don't make reverseproxy for websockets you will see error like this and it looks like a bug in the code.

[IgorA100]

I couldn't reproduce the issue.
But please apply this PR: #5027
And let me know if the issue is resolved.
If the issue persists, please describe in more detail what steps need to be taken and which browser is used to reproduce the problem.

[atlochowski]

You should use go2rtc as a Default Player for camera.
if you forgot to add to <VirtualHost *:443>

ProxyPass        /go2rtc/api/ws  ws://127.0.0.1:1984/api/ws
ProxyPassReverse /go2rtc/api/ws  ws://127.0.0.1:1984/api/ws

to /etc/apache2/sites-enabled/000-default.conf
and try to see playback from camera you will see this error.
So you should use https for zoneminder
I use firefox 153

[atlochowski]

I couldn't reproduce the issue. But please apply this PR: #5027 And let me know if the issue is resolved. If the issue persists, please describe in more detail what steps need to be taken and which browser is used to reproduce the problem.

I applied your patch, rebooted zoneminder and it's still
TypeError: this.onerror is not a function onconnect/<@https://***.pl/zm/js/video-rtc.js:308:56

[IgorA100]

I can't reproduce the problem.
Please provide a screenshot of the browser console showing the error and previous messages.

[IgorA100]

I applied your patch, rebooted zoneminder and it's still

After applying PR: #5027 such error TypeError: this.onerror is not a function onconnect/<@https://***.pl/zm/js/video-rtc.js:308:56 cannot occur, because in line 308 it will no longer be this.ws.addEventListener('error', (ev) => this.onerror(ev)); but this.ws.addEventListener('error', (ev) => this.onerrorGo2rtc(ev));

[IgorA100]

@connortechnology
I think using the commit 12cb7d9#diff-2328bfaeba6c272b4151872b06eb22e0f7596c668ef22829727bb8ca6c1b2a92 is a questionable decision.
When switching multiple monitors, we need to clean up all references as much as possible to prevent memory leaks and avoid unpredictable behavior.
Using .onerror for go2rtc is probably not the best option, so I renamed it to #5027 and cleaning up .onerror is probably unnecessary.
In general, time will tell.

[connortechnology]

@atlochowski some potential fixes have been merged, can you update and report back?

[atlochowski]

@connortechnology I will try but have to wait for repo synchronization because there is problem with check sum.

[atlochowski]

can't see any errors so it looks like solved