fix: improve error handling in Extract method and skip functions with "go:" prefix

Author: Zxilly

internal/disasm/interface.go

@@ -3,6 +3,7 @@ package disasm
 import (
 	"errors"
 	"fmt"
+	"log/slog"
 	"unicode/utf8"
 
 	"github.com/Zxilly/go-size-analyzer/internal/entity"
@@ -83,11 +84,9 @@ func (e *Extractor) Validate(addr, size uint64) bool {
 }
 
 func (e *Extractor) Extract(start, end uint64) []PossibleStr {
-	if start < e.textStart {
-		panic(fmt.Errorf("start address %#x is before text segment %#x", start, e.textStart))
-	}
-	if end > e.textEnd {
-		panic(fmt.Errorf("end address %#x is after text segment %#x", end, e.textEnd))
+	if start < e.textStart || end > e.textEnd || start > end {
+		slog.Debug("skipping function outside text section", "start", fmt.Sprintf("%#x", start), "end", fmt.Sprintf("%#x", end), "textStart", fmt.Sprintf("%#x", e.textStart), "textEnd", fmt.Sprintf("%#x", e.textEnd))
+		return nil
 	}
 
 	code := e.text[start-e.textStart : end-e.textStart]

internal/entity/package.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"maps"
+	"strings"
 	"sync"
 
 	"github.com/ZxillyFork/gore"
@@ -90,6 +91,9 @@ func NewPackageWithGorePackage(gp *gore.Package, name string, typ PackageType, p
 	}
 
 	for _, f := range gp.Functions {
+		if strings.HasPrefix(f.Name, "go:") {
+			continue
+		}
 		src, _, _ := pclntab.PCToLine(f.Offset)
 		sf := getFunction(f)
 		sf.Type = FuncTypeFunction

scripts/tool/remote.py

@@ -76,22 +76,26 @@ def generated_filepath(self, typ: TestType):
 
     def run_test(self, gsa: GSAInstance, log_typ: callable(TestType), timeout=240):
         threads = []
+        errors = []
 
         draw = not self.name.startswith("bin-")
 
         def run(pargs: list[str], typ: TestType):
-            figure_output = self.performance_figure_filepath(typ)
-            if not draw:
-                figure_output = None
-
-            gsa.run_with_figure(*pargs,
-                                output=self.output_filepath(typ),
-                                profiler_dir=self.profiler_dir(typ),
-                                figure_name=self.name,
-                                timeout=timeout,
-                                figure_output=figure_output)
-
-            log_typ(typ)
+            try:
+                figure_output = self.performance_figure_filepath(typ)
+                if not draw:
+                    figure_output = None
+
+                gsa.run_with_figure(*pargs,
+                                    output=self.output_filepath(typ),
+                                    profiler_dir=self.profiler_dir(typ),
+                                    figure_name=self.name,
+                                    timeout=timeout,
+                                    figure_output=figure_output)
+
+                log_typ(typ)
+            except Exception as e:
+                errors.append(e)
 
         if TestType.TEXT_TEST in self.type:
             threads.append(Thread(target=run, args=(["-f", "text", "--verbose", self.path], TestType.TEXT_TEST)))
@@ -127,6 +131,9 @@ def run(pargs: list[str], typ: TestType):
         for t in threads:
             t.join()
 
+        if errors:
+            raise errors[0]
+
 
 class RemoteBinaryType(Enum):
     RAW = "raw"