1.0.0-RC#22
Merged
Merged
Conversation
JesusMcCloud
force-pushed
the
release/1.0.0-RC
branch
from
January 22, 2026 18:33
ea5f656 to
f7f74b2
Compare
Closed
JesusMcCloud
marked this pull request as ready for review
January 23, 2026 12:42
Closed
nodh
reviewed
Jan 27, 2026
nodh
requested changes
Jan 27, 2026
JesusMcCloud
commented
Jan 27, 2026
* Document leaked keyboxes
Co-authored-by: Christian Kollmann <christian.kollmann@a-sit.at>
* pass full CSR for challenge validation * add side-effect-free callback for introspect validated challenge * make all side-effect-free callbacks suspend
JesusMcCloud
force-pushed
the
release/1.0.0-RC
branch
from
January 27, 2026 14:43
091938a to
18c10b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion points:
TODOs:
Full migration guide wrt. config changes and API changesDocs and API docs proof reading(General task)Social Previews for all pagesSocial Preview for docs #38ExceptionsCheck for exception annotations where required (constructors)In particular, re-evaluate configuration exceptionRe-evaluate exceptions throws during initialisationsMake sure internal errors are really always bugs and always add a link to creating an issue to the messageTesting:
Test contracts (semantically, not Kotlin Contracts) and explicitly document implicit contracts/behaviourSupreme Verifier constructor params propagate correctly to Makoto and nonce checkerException Mapping (Makoto Exceptions to AttestationResponse.Error)CSR attributes and CSR extensions are correctly encodedTest if CSR attributes and extensions are correctly encoded #40Auth prompts are correctly displayedcheck if Auth prompts are correctly displayed #41