Skip to content

1.0.0-RC#22

Merged
JesusMcCloud merged 23 commits into
developmentfrom
release/1.0.0-RC
Jan 27, 2026
Merged

1.0.0-RC#22
JesusMcCloud merged 23 commits into
developmentfrom
release/1.0.0-RC

Conversation

@JesusMcCloud

@JesusMcCloud JesusMcCloud commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Discussion points:

  • Default Nonce validity duration
  • Is there more potential to simplify APIs and remove old stuff/reduce API surface?
  • Do we want multiple Makoto Constructors to ensure that at least iOS or Android is enabled, or do we just throw if both configs passed are null and expose the constructor with two nullable parameters?

TODOs:

  • Testing (see below)
  • Wait for info on SW roots and amend docs (and potentially code) accordingly
  • Full migration guide wrt. config changes and API changes
  • Docs and API docs proof reading (General task)
  • Social Previews for all pagesSocial Preview for docs #38
  • Exceptions
    • Check for exception annotations where required (constructors)
    • In particular, re-evaluate configuration exception
    • Re-evaluate exceptions throws during initialisations
    • Make sure internal errors are really always bugs and always add a link to creating an issue to the message

Testing:

@JesusMcCloud JesusMcCloud mentioned this pull request Jan 22, 2026
@JesusMcCloud
JesusMcCloud marked this pull request as ready for review January 23, 2026 12:42
@JesusMcCloud JesusMcCloud mentioned this pull request Jan 26, 2026
@JesusMcCloud
JesusMcCloud requested a review from nodh January 26, 2026 12:25
Comment thread supreme/common/src/commonMain/kotlin/parser/AttestationExtension.kt
Comment thread serverside/roboto/src/main/kotlin/Configuration.kt Outdated
Comment thread serverside/roboto/src/main/kotlin/Configuration.kt Outdated
Comment thread serverside/makoto/src/main/kotlin/IosAttestationConfiguration.kt Outdated
Comment thread serverside/makoto/src/main/kotlin/IosAttestationConfiguration.kt Outdated
Comment thread serverside/makoto/src/main/kotlin/Makoto.kt Outdated
Comment thread serverside/roboto/src/main/kotlin/AndroidRevocationList.kt Outdated
Comment thread supreme/common/src/commonMain/kotlin/parser/AttestationValue.kt
Comment thread build.gradle.kts
Comment thread .github/workflows/test-android.yml
Comment thread supreme/client/src/commonTest/kotlin/EndToEndTest.kt
Comment thread serverside/roboto/src/main/kotlin/AndroidRevocationList.kt Outdated
@JesusMcCloud
JesusMcCloud requested a review from nodh January 27, 2026 13:23

@nodh nodh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

JesusMcCloud and others added 3 commits January 27, 2026 15:40
* Document leaked keyboxes
Co-authored-by: Christian Kollmann <christian.kollmann@a-sit.at>
* pass full CSR for challenge validation
* add side-effect-free callback for introspect validated challenge
* make all side-effect-free callbacks suspend
@JesusMcCloud
JesusMcCloud merged commit c3825f6 into development Jan 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants