Skip to content

Commit 316bef4

Browse files
committed
feat(v3-uplift): governance header buttons & top-panel/list tidy-ups
- GovernanceTopPanel: the external-link buttons are outlined text+icon buttons (endIcon = ArrowUpRightIcon in fgp-3) with 0.5rem gap and title-case labels - ProposalListHeader: drop the redundant "Filter" label (desktop + mobile), keeping the filter Select - DelegatedInfoPanel: strip the width override on the "Set up delegation" button (stays full-width via the flex-column parent)
1 parent ab9d148 commit 316bef4

8 files changed

Lines changed: 13 additions & 29 deletions

File tree

src/locales/el/messages.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/en/messages.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/en/messages.po

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3577,11 +3577,6 @@ msgstr "AToken supply is not zero"
35773577
msgid "Debt"
35783578
msgstr "Debt"
35793579

3580-
#: src/modules/governance/ProposalListHeader.tsx
3581-
#: src/modules/governance/ProposalListHeader.tsx
3582-
msgid "Filter"
3583-
msgstr "Filter"
3584-
35853580
#: src/components/incentives/EtherfiIncentivesTooltipContent.tsx
35863581
msgid "Learn more about the Ether.fi program"
35873582
msgstr "Learn more about the Ether.fi program"

src/locales/es/messages.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/locales/fr/messages.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/modules/governance/DelegatedInfoPanel.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ export const DelegatedInfoPanel = () => {
214214
<Box sx={{ p: 6, display: 'flex', flexDirection: 'column', gap: 2 }}>
215215
<Button
216216
size="large"
217-
sx={{ width: '100%' }}
218217
variant="contained"
219218
disabled={disableButton}
220219
onClick={() => openGovDelegation()}

src/modules/governance/GovernanceTopPanel.tsx

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { ChainId } from '@aave/contract-helpers';
2-
import { ExternalLinkIcon } from '@heroicons/react/outline';
32
import { Trans } from '@lingui/macro';
4-
import { Box, Button, SvgIcon, Typography, useMediaQuery, useTheme } from '@mui/material';
3+
import { Box, Button, Typography, useMediaQuery, useTheme } from '@mui/material';
54
import * as React from 'react';
65
import { ChainAvailabilityText } from 'src/components/ChainAvailabilityText';
6+
import { ArrowUpRightIcon } from 'src/components/icons/ArrowUpRightIcon';
77
import { Link } from 'src/components/primitives/Link';
88
import { useRootStore } from 'src/store/root';
99
import { GENERAL } from 'src/utils/events';
@@ -22,19 +22,15 @@ function ExternalLink({ text, href }: ExternalLinkProps) {
2222
<Button
2323
variant="outlined"
2424
size="small"
25-
sx={{ minWidth: 'unset' }}
2625
component={Link}
2726
href={href}
2827
target="_blank"
2928
rel="noopener"
3029
onClick={() => trackEvent(GENERAL.EXTERNAL_LINK, { Link: text })}
30+
endIcon={<ArrowUpRightIcon sx={{ color: 'fgp-3' }} />}
31+
sx={{ minWidth: 'unset' }}
3132
>
32-
<Box sx={{ display: 'flex', alignItems: 'center' }}>
33-
{text}
34-
<SvgIcon sx={{ ml: 1, fontSize: 14 }}>
35-
<ExternalLinkIcon />
36-
</SvgIcon>
37-
</Box>
33+
{text}
3834
</Button>
3935
);
4036
}
@@ -79,15 +75,15 @@ export const GovernanceTopPanel = () => {
7975
sx={{
8076
display: 'flex',
8177
alignItems: 'center',
82-
gap: '16px',
78+
gap: '0.5rem',
8379
flexWrap: 'wrap',
8480
maxWidth: 'sm',
8581
}}
8682
>
87-
<ExternalLink text="SNAPSHOTS" href="https://snapshot.org/#/aave.eth" />
88-
<ExternalLink text="FORUM" href="https://governance.aave.com/" />
83+
<ExternalLink text="Snapshots" href="https://snapshot.org/#/aave.eth" />
84+
<ExternalLink text="Forum" href="https://governance.aave.com/" />
8985
<ExternalLink text="FAQ" href="https://aave.com/docs/ecosystem/governance" />
90-
<ExternalLink text="GOVERNANCE V2" href="https://governance-v2.aave.com/" />
86+
<ExternalLink text="Governance V2" href="https://governance-v2.aave.com/" />
9187
</Box>
9288
</TopInfoPanel>
9389
);

src/modules/governance/ProposalListHeader.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@ export const ProposalListHeaderDesktop: React.FC<ProposalListHeaderElementProps>
3737
<Typography variant="h3" sx={{ flexGrow: 1 }}>
3838
<Trans>Proposals</Trans>
3939
</Typography>
40-
<Typography>
41-
<Trans>Filter</Trans>
42-
</Typography>
4340
<Select
4441
id="filter"
4542
value={proposalFilter}
@@ -81,9 +78,6 @@ export const ProposalListHeaderMobile: React.FC<ProposalListHeaderElementProps>
8178
searchPlaceholder="Search proposals"
8279
/>
8380
<Box sx={{ display: 'flex', alignItems: 'center', gap: 4 }}>
84-
<Typography>
85-
<Trans>Filter</Trans>
86-
</Typography>
8781
<Select
8882
id="filter"
8983
value={proposalFilter}

0 commit comments

Comments
 (0)