Fix CI

[abhiabhi94]

@claude can you look at this CI run: https://github.com/abhiabhi94/job-board/actions/runs/21093023213/job/60666839566 and fix it. The CI was working earlier.

Specifically this traceback for the failure is

____________________________ test_get_jobs_sorting _____________________________

db_session = <sqlalchemy.orm.session.Session object at 0x7f5983158d70>
client = <FlaskClient <Flask 'job_board.views'>>
captured_templates = [TemplateContent(template=<Template 'jobs/index.html'>, context={'jobs': [Job(id=77, title='Job 2', description='Anoth...e240fb645041dca4ab3050a54e22f5961cfcf2d9,sentry-transaction=get_jobs,sentry-sample_rate=0.1,sentry-sampled=false">')})]

    def test_get_jobs_sorting(db_session, client, captured_templates):
        response = client.get("/", query_string={"sort": "blah"})
        assert response.status_code == 400
    
        link_1 = "https://example.com/job1"
        link_2 = "https://example.com/job2"
        job_1 = JobListing(
            link=link_1,
            title="Job 1",
            min_salary=30_000,
            is_remote=True,
            tags=["python", "remote"],
            description="A job description",
            payload="some data",
            company_name="Test Company",
        )
        job_2 = JobListing(
            link=link_2,
            title="Job 2",
            min_salary=25_000,
            is_remote=True,
            description="Another job description",
            tags=["python"],
            payload="some data",
            company_name="Test Company",
        )
    
        store_jobs([job_1, job_2])
    
        response = client.get(
            "/",
            query_string={
                "sort": "salary_desc",
            },
        )
    
        assert response.status_code == 200
        context = captured_templates[-1].context
>       assert [j.link for j in context["jobs"]] == [link_1, link_2]
E       AssertionError: assert ['https://exa...ple.com/job1'] == ['https://exa...ple.com/job2']
E         
E         At index 0 diff: 'https://example.com/job2' != 'https://example.com/job1'
E         
E         Full diff:
E           [
E         +     'https://example.com/job2',
E               'https://example.com/job1',
E         -     'https://example.com/job2',
E           ]

tests/test_views.py:248: AssertionError
----------------------------- Captured stderr call -----------------------------
+0000 17/01/2026 10:45:51 AM - job-board - INFO - Stored 2 new jobs
+0000 17/01/2026 10:45:51 AM - job-board - INFO - Stored tags for 2 jobs
+0000 17/01/2026 10:45:51 AM - job-board - INFO - Stored 2 new payloads
------------------------------ Captured log call -------------------------------
INFO     job-board:models.py:289 Stored 2 new jobs
INFO     job-board:models.py:362 Stored tags for 2 jobs
INFO     job-board:models.py:395 Stored 2 new payloads
=============================== warnings summary ===============================
tests/test_models.py::test_location_check_constraint
  /home/runner/work/job-board/job-board/tests/conftest.py:62: SAWarning: transaction already deassociated from connection
    transaction.rollback()

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_views.py::test_get_jobs_sorting - AssertionError: assert ['https://exa...ple.com/job1'] == ['https://exa...ple.com/job2']
  
  At index 0 diff: 'https://example.com/job2' != 'https://example.com/job1'
  
  Full diff:
    [
  +     'https://example.com/job2',
        'https://example.com/job1',
  -     'https://example.com/job2',
    ]
================== 1 failed, 120 passed, 1 warning in 31.41s ===================
Error: Process completed with exit code 1.

[claude]

Claude finished @abhiabhi94's task in 2m 13s —— View job • claude/issue-77-20260117-1157 • Create PR ➔

---

CI Failure Fixed

I've identified and fixed the issue causing test_get_jobs_sorting to fail.

Root Cause

The test creates two jobs with the same max_salary=None:

• job_1: min_salary=30,000, max_salary=None
• job_2: min_salary=25,000, max_salary=None

When sorting by salary_desc, the code was using only Job.max_salary.desc(). Since both jobs had NULL max_salary values, the ordering was non-deterministic, causing the test to fail intermittently.

Solution

Updated the salary sorting logic to:

1. Use nullslast() to explicitly handle NULL values (pushing them to the end)
2. Add secondary sort by min_salary for consistent ordering when max_salary values are equal or NULL
3. Updated filter_jobs() to accept both single and tuple sort expressions

Changes Made

• job_board/views.py:71 - Changed from single sort to tuple: (Job.max_salary.desc().nullslast(), Job.min_salary.desc().nullslast())
• job_board/query.py:61 - Updated type hint: order_by: sa.UnaryExpression | tuple[sa.UnaryExpression, ...]
• job_board/query.py:75-84 - Added logic to handle both single and tuple order_by values

Next Steps

The changes have been committed and pushed to the branch. Please note:

• I don't have permission to run the test suite or linting checks locally
• The CI will run automatically on the PR and verify the fix
• You may want to run pre-commit run --all-files and ENV=test pytest locally to verify

| Branch