Commit 3197d28
committed
feat(ui): paint trial glyph by QA verdict, keep shape as outcome
A GOOD_FAILURE trial rendered as a red X with a nearly invisible 4px
green corner dot, and the analyzer legend labeled that dot "Pass" — an
expected failure was indistinguishable from a bad one, or read as a
success. The mirror case (BAD_SUCCESS) showed an unqualified green
check.
Make the cell semiotics uniform: glyph shape encodes the execution
outcome (check/cross), fill color encodes the QA verdict once the trial
is classified (green = good, red = bad). A good failure is now a green
X, a bad success a red check; good-success and bad-failure look exactly
as before.
- status-config: getQaGlyphMatrixClass(status, classification) holds the
2x2 rule; shared ANALYSIS_CLASSIFICATION_LABELS. Only binary outcomes
take the tone — partials keep the warm ramp, transitional states stay
neutral.
- trials matrix: apply the tone fill, show the corner dot only when it
still carries information (QA running/failed, classified partial or
error), and use the classification label in aria-label/tooltip.
- legend: rename tone chips Pass/Fail to Good/Bad rendered as a check+X
glyph pair, and rewrite the anatomy demo to teach shape=result,
color=QA verdict.
- trial-detail navigator: same override via the shared helper.
Verified with tsc, eslint, and a browser-rendered harness covering all
classification x outcome combinations (harness removed after).1 parent 353be62 commit 3197d28
3 files changed
Lines changed: 147 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
79 | 80 | | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| 84 | + | |
83 | 85 | | |
| 86 | + | |
84 | 87 | | |
85 | 88 | | |
86 | 89 | | |
| |||
331 | 334 | | |
332 | 335 | | |
333 | 336 | | |
334 | | - | |
| 337 | + | |
335 | 338 | | |
336 | 339 | | |
337 | 340 | | |
338 | 341 | | |
339 | | - | |
| 342 | + | |
340 | 343 | | |
341 | 344 | | |
342 | 345 | | |
| |||
1562 | 1565 | | |
1563 | 1566 | | |
1564 | 1567 | | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
1565 | 1584 | | |
1566 | 1585 | | |
1567 | 1586 | | |
| |||
1575 | 1594 | | |
1576 | 1595 | | |
1577 | 1596 | | |
1578 | | - | |
1579 | | - | |
1580 | | - | |
1581 | | - | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
| 1601 | + | |
| 1602 | + | |
| 1603 | + | |
| 1604 | + | |
1582 | 1605 | | |
1583 | 1606 | | |
1584 | 1607 | | |
| |||
1593 | 1616 | | |
1594 | 1617 | | |
1595 | 1618 | | |
1596 | | - | |
| 1619 | + | |
1597 | 1620 | | |
1598 | 1621 | | |
1599 | 1622 | | |
1600 | 1623 | | |
1601 | 1624 | | |
| 1625 | + | |
| 1626 | + | |
| 1627 | + | |
| 1628 | + | |
| 1629 | + | |
| 1630 | + | |
| 1631 | + | |
| 1632 | + | |
| 1633 | + | |
1602 | 1634 | | |
1603 | | - | |
| 1635 | + | |
1604 | 1636 | | |
1605 | 1637 | | |
1606 | 1638 | | |
1607 | 1639 | | |
1608 | | - | |
1609 | | - | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
1610 | 1643 | | |
1611 | 1644 | | |
1612 | 1645 | | |
1613 | | - | |
1614 | | - | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
1615 | 1649 | | |
1616 | 1650 | | |
1617 | 1651 | | |
1618 | 1652 | | |
1619 | 1653 | | |
1620 | | - | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
1621 | 1659 | | |
1622 | 1660 | | |
1623 | 1661 | | |
| |||
2435 | 2473 | | |
2436 | 2474 | | |
2437 | 2475 | | |
| 2476 | + | |
| 2477 | + | |
| 2478 | + | |
| 2479 | + | |
| 2480 | + | |
| 2481 | + | |
| 2482 | + | |
| 2483 | + | |
| 2484 | + | |
| 2485 | + | |
| 2486 | + | |
| 2487 | + | |
| 2488 | + | |
| 2489 | + | |
| 2490 | + | |
| 2491 | + | |
| 2492 | + | |
| 2493 | + | |
| 2494 | + | |
2438 | 2495 | | |
2439 | 2496 | | |
2440 | 2497 | | |
| |||
2476 | 2533 | | |
2477 | 2534 | | |
2478 | 2535 | | |
2479 | | - | |
| 2536 | + | |
2480 | 2537 | | |
2481 | | - | |
| 2538 | + | |
2482 | 2539 | | |
2483 | 2540 | | |
2484 | 2541 | | |
| |||
2487 | 2544 | | |
2488 | 2545 | | |
2489 | 2546 | | |
2490 | | - | |
| 2547 | + | |
2491 | 2548 | | |
2492 | 2549 | | |
2493 | 2550 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | 81 | | |
| 82 | + | |
81 | 83 | | |
82 | 84 | | |
83 | 85 | | |
| |||
1255 | 1257 | | |
1256 | 1258 | | |
1257 | 1259 | | |
| 1260 | + | |
| 1261 | + | |
| 1262 | + | |
| 1263 | + | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
| 1268 | + | |
| 1269 | + | |
| 1270 | + | |
| 1271 | + | |
| 1272 | + | |
| 1273 | + | |
1258 | 1274 | | |
1259 | 1275 | | |
1260 | 1276 | | |
| |||
1270 | 1286 | | |
1271 | 1287 | | |
1272 | 1288 | | |
1273 | | - | |
| 1289 | + | |
1274 | 1290 | | |
1275 | 1291 | | |
1276 | 1292 | | |
| |||
1279 | 1295 | | |
1280 | 1296 | | |
1281 | 1297 | | |
1282 | | - | |
1283 | | - | |
| 1298 | + | |
| 1299 | + | |
1284 | 1300 | | |
1285 | 1301 | | |
1286 | 1302 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
28 | 83 | | |
29 | 84 | | |
30 | 85 | | |
| |||
0 commit comments