fixing CC trajectory issue; frontend badges

Author: RishiDesai

frontend/next-env.d.ts

@@ -1,6 +1,6 @@
 /// <reference types="next" />
 /// <reference types="next/image-types/global" />
-import "./.next/types/routes.d.ts";
+import "./.next/dev/types/routes.d.ts";
 
 // NOTE: This file should not be edited
 // see https://nextjs.org/docs/app/api-reference/config/typescript for more information.

frontend/src/components/experiment-detail-view.tsx

@@ -503,6 +503,49 @@ export function ExperimentDetailView({
     });
   }, [tasksForExperiment, searchParams, buildTrialGroups]);
 
+  // Re-sync the open drawer with freshly-loaded trial data. On direct URL
+  // loads the drawer opens as soon as the lightweight task shells arrive,
+  // before trial pages stream in; without this, ``trialGroups`` stays empty
+  // and the task↔trial nav row (``onNavigateToFirstTrial``) never appears.
+  // Also handles the case where trials finish loading while a drawer opened
+  // from a row click is already mounted.
+  useEffect(() => {
+    if (!drawerState) return;
+    const liveTask = tasksForExperiment.find(
+      (t) => t.id === drawerState.task.id,
+    );
+    if (!liveTask) return;
+    const liveTrialCount = liveTask.trials?.length ?? 0;
+    const snapshotTrialCount = drawerState.task.trials?.length ?? 0;
+    if (
+      liveTask === drawerState.task &&
+      liveTrialCount === snapshotTrialCount
+    ) {
+      return;
+    }
+    const { trialGroups, orderedTrials } = buildTrialGroups(liveTask);
+    const foundTrialIndex = drawerState.trial
+      ? orderedTrials.findIndex((t) => t.id === drawerState.trial!.id)
+      : -1;
+    const resolvedTrialIndex = foundTrialIndex >= 0 ? foundTrialIndex : null;
+    const resolvedTrial =
+      resolvedTrialIndex != null
+        ? orderedTrials[resolvedTrialIndex]
+        : drawerState.trial;
+    const resolvedTaskIndex = tasksForExperiment.indexOf(liveTask);
+    setDrawerState({
+      ...drawerState,
+      task: liveTask,
+      taskIndex:
+        resolvedTaskIndex >= 0 ? resolvedTaskIndex : drawerState.taskIndex,
+      orderedTasks: tasksForExperiment,
+      trial: resolvedTrial,
+      trialIndex: resolvedTrialIndex,
+      orderedTrials,
+      trialGroups,
+    });
+  }, [tasksForExperiment, drawerState, buildTrialGroups]);
+
   const summary = useMemo(
     () => buildExperimentSummary(tasksForExperiment),
     [tasksForExperiment],

frontend/src/components/trajectory-viewer.tsx

@@ -175,7 +175,10 @@ function ContentRenderer({
       {content.map((part, idx) => {
         if (part.type === "text") {
           return (
-            <div key={idx} className="whitespace-pre-wrap wrap-break-word text-sm">
+            <div
+              key={idx}
+              className="whitespace-pre-wrap wrap-break-word text-sm"
+            >
               {part.text}
             </div>
           );
@@ -694,19 +697,32 @@ function StepContent({
 
 interface TrajectoryViewerProps {
   trialId: string;
+  /**
+   * Whether the backend recorded an ATIF trajectory for this trial
+   * (mirrors ``TrialResponse.has_trajectory``).  When ``false`` we skip
+   * the fetch entirely — the endpoint would just return ``null`` after
+   * a multi-second S3 probe, and some trials (older rows with a stale
+   * ``harbor_result_path`` pointing at the decommissioned Modal volume)
+   * additionally surface a spurious 403 on the local-fallback branch.
+   * ``undefined`` preserves legacy behaviour (always fetch) for
+   * consumers that haven't been updated.
+   */
+  hasTrajectory?: boolean;
   apiBaseUrl?: string;
 }
 
 export function TrajectoryViewer({
   trialId,
+  hasTrajectory,
   apiBaseUrl = "/api",
 }: TrajectoryViewerProps) {
+  const shouldFetch = hasTrajectory !== false;
   const {
     data: trajectory,
     isLoading,
     error,
   } = useSWR<Trajectory | null>(
-    `${apiBaseUrl}/trials/${trialId}/trajectory`,
+    shouldFetch ? `${apiBaseUrl}/trials/${trialId}/trajectory` : null,
     fetcher,
     {
       revalidateOnFocus: false,

frontend/src/components/trial-detail-panel.tsx

@@ -30,7 +30,6 @@ import {
   ChevronUp,
   ChevronLeft,
   ChevronRight,
-  Ban,
   RotateCcw,
   Loader2,
   Microscope,
@@ -60,6 +59,7 @@ import {
 import { HarborStageTimeline } from "@/components/harbor-stage-timeline";
 import { HarborStageBadge } from "@/components/harbor-stage-badge";
 import { QueueKeyIcon } from "@/components/queue-key-icon";
+import { StatusIcon } from "@/components/status-icon";
 
 interface TrialDetailPanelProps {
   isOpen: boolean;
@@ -522,10 +522,10 @@ export function TrialDetailPanel({
                     groupTrial.error_message,
                   );
                   const groupConfig = STATUS_CONFIG[groupStatus];
-                  const badgeLabel =
-                    groupStatus === "partial"
-                      ? formatPartialRewardBadgeValue(groupTrial.reward)
-                      : groupConfig.symbol;
+                  const isPartial = groupStatus === "partial";
+                  const partialLabel = isPartial
+                    ? formatPartialRewardBadgeValue(groupTrial.reward)
+                    : null;
                   const isActive = index === currentGroupTrialIndex;
                   return (
                     <Button
@@ -535,26 +535,26 @@ export function TrialDetailPanel({
                       size="icon"
                       onClick={() => navigateToGroupTrial(index)}
                       className={cn(
-                        "flex h-5 w-5 items-center justify-center rounded-sm border p-0 font-mono font-semibold leading-none transition",
-                        groupStatus === "partial"
-                          ? "text-[8px] tracking-[-0.03em]"
-                          : "text-sm",
+                        "flex h-5 w-5 shrink-0 items-center justify-center rounded-sm border p-0 leading-none transition hover:opacity-90",
                         groupConfig.matrixClass,
+                        isPartial
+                          ? "font-mono text-[8px] font-semibold tracking-[-0.03em]"
+                          : "",
                         isActive
                           ? "ring-2 ring-primary/60 ring-offset-1 ring-offset-background"
                           : "",
                       )}
-                      aria-label={`Trial ${index + 1}`}
+                      style={getRewardStyle(groupTrial.reward)}
+                      aria-label={`Trial ${index + 1} ${groupConfig.shortLabel}`}
                       title={`${groupConfig.shortLabel} • Trial ${index + 1}`}
                     >
-                      {groupStatus === "pending" ||
-                      groupStatus === "queued" ||
-                      groupStatus === "running" ? (
-                        <Loader2 className="h-3.5 w-3.5" />
-                      ) : groupStatus === "harness-error" ? (
-                        <Ban className="h-3.5 w-3.5" />
+                      {isPartial ? (
+                        partialLabel
                       ) : (
-                        badgeLabel
+                        <StatusIcon
+                          status={groupStatus}
+                          className="h-3.5 w-3.5"
+                        />
                       )}
                     </Button>
                   );
@@ -950,7 +950,11 @@ export function TrialDetailPanel({
             value="trajectory"
             className="m-0 h-full overflow-auto p-0"
           >
-            <TrajectoryViewer trialId={trial.id} apiBaseUrl={apiBaseUrl} />
+            <TrajectoryViewer
+              trialId={trial.id}
+              hasTrajectory={trial.has_trajectory}
+              apiBaseUrl={apiBaseUrl}
+            />
           </TabsContent>
         </div>
       </Tabs>

frontend/src/lib/types.ts

@@ -76,6 +76,7 @@ export interface Trial {
   output_tokens?: number | null;
   cost_usd?: number | null;
   cost_is_estimated?: boolean | null;
+  has_trajectory?: boolean;
   created_at: string;
   started_at?: string | null;
   finished_at?: string | null;

oddish/alembic/versions/d5e6f7a8b9c0_null_stale_data_harbor_result_paths.py

@@ -0,0 +1,56 @@
+"""null stale /data/harbor harbor_result_path values
+
+Commit d2154f5 ("removed modal volume stuff") stopped mounting the
+shared ``/data`` Modal Volume and switched ``harbor_jobs_dir`` from
+``/data/harbor`` to each container's ephemeral ``/tmp/harbor-jobs``.
+Any ``trials.harbor_result_path`` written before that commit still
+references ``/data/harbor/...`` even though that path can never resolve
+on the new containers.  The column is a legacy breadcrumb anyway — the
+trial's artifacts are in S3 (see
+``StorageClient.upload_trial_results``) and the local dir is deleted
+immediately after upload by ``_cleanup_uploaded_job_dir`` — so these
+rows are pure noise.
+
+Beyond the noise, leaving them set tripped the path-containment guard
+in ``oddish.core.trial_io._resolve_local_job_dir``: trajectory / result
+reads for trials without an S3 trajectory would fall through to the
+local-fallback branch, hit a path outside the current
+``harbor_jobs_dir``, and surface as a confusing ``403`` to the
+frontend.  The guard has been softened to return ``None`` for that
+case, but nulling the stale rows removes the dead walk entirely and
+makes ``harbor_result_path`` stop lying about where artifacts live.
+
+This migration is idempotent: running it repeatedly is a no-op once
+the stale rows are nulled.
+
+Revision ID: d5e6f7a8b9c0
+Revises: c4b5a6d7e8f9
+Create Date: 2026-04-23 16:30:00.000000
+"""
+
+from typing import Sequence, Union
+
+from alembic import op
+
+
+revision: str = "d5e6f7a8b9c0"
+down_revision: Union[str, Sequence[str], None] = "c4b5a6d7e8f9"
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def upgrade() -> None:
+    op.execute(
+        """
+        UPDATE trials
+        SET harbor_result_path = NULL
+        WHERE harbor_result_path LIKE '/data/harbor/%'
+        """
+    )
+
+
+def downgrade() -> None:
+    # Irreversible: the original per-row values are not recoverable, and
+    # they pointed at a volume that no longer exists, so there's nothing
+    # useful to restore.
+    pass

oddish/src/oddish/core/trial_io.py

@@ -61,7 +61,17 @@ def _should_cache_trial(trial: TrialModel) -> bool:
 
 
 def _resolve_local_job_dir(trial: TrialModel) -> Path | None:
-    """Resolve and validate the local Harbor job directory for a trial."""
+    """Resolve and validate the local Harbor job directory for a trial.
+
+    Returns ``None`` (not a 403) when ``harbor_result_path`` points outside the
+    current container's ``harbor_jobs_dir``.  This happens for trials run
+    before the Modal Volume was removed (they stored ``/data/harbor/...``
+    paths that no longer resolve on the ephemeral-``/tmp`` containers);
+    those trials just have no local fallback and should fall through to
+    the "no trajectory / no result" branch rather than surfacing a
+    spurious auth-looking error.  The path comes from our own DB, not
+    user input, so there's no traversal risk to guard against here.
+    """
     if not trial.harbor_result_path:
         return None
 
@@ -76,9 +86,7 @@ def _resolve_local_job_dir(trial: TrialModel) -> Path | None:
         base_dir not in result_path_resolved.parents
         and result_path_resolved != base_dir
     ):
-        raise HTTPException(
-            status_code=403, detail="Refusing to read trial outside harbor_jobs_dir"
-        )
+        return None
 
     job_dir = result_path_resolved.parent
     if not job_dir.exists() or not job_dir.is_dir():