Standardize environment name from "prod" to "production" (#93)

The backend Logfire env, browser Logfire env, and @vercel/otel
deployment.environment all explicitly mapped VERCEL_ENV/MODAL_APP=production
to 'prod'. @vercel/otel also auto-injects deployment.environment from
VERCEL_ENV, so edge spans ended up tagged both 'prod' and 'production' in
Logfire. Standardize on 'production' so every layer agrees and matches
Vercel/Logfire's own convention.

Co-authored-by: Claude <noreply@anthropic.com>

Author: pfbyjy

backend/observability.py

@@ -44,7 +44,7 @@ def _resolve_environment() -> str:
 
     modal_app = os.environ.get("MODAL_APP_NAME", "")
     if modal_app == "oddish":
-        return "prod"
+        return "production"
     if modal_app.startswith("oddish-pr-"):
         pr = modal_app.removeprefix("oddish-pr-")
         if pr:

frontend/src/instrumentation.ts

@@ -21,7 +21,7 @@ export function register() {
   const environment = (() => {
     const explicit = process.env.LOGFIRE_ENVIRONMENT;
     if (explicit) return explicit;
-    if (process.env.VERCEL_ENV === "production") return "prod";
+    if (process.env.VERCEL_ENV === "production") return "production";
     const pr = process.env.VERCEL_GIT_PULL_REQUEST_ID;
     return pr ? `preview-pr-${pr}` : "preview";
   })();

frontend/src/lib/observability.ts

@@ -30,7 +30,7 @@ function resolveEnvironment(): string {
   // Per-PR bucket so previews don't all share one "preview" env. Keyed off
   // `NEXT_PUBLIC_VERCEL_ENV` not `NODE_ENV` — the latter is "production"
   // for PR-preview builds too.
-  if (process.env.NEXT_PUBLIC_VERCEL_ENV === "production") return "prod";
+  if (process.env.NEXT_PUBLIC_VERCEL_ENV === "production") return "production";
   const pr = process.env.NEXT_PUBLIC_VERCEL_GIT_PULL_REQUEST_ID;
   return pr ? `preview-pr-${pr}` : "preview";
 }