linting fixes

Author: MeghP89

src/App.tsx

@@ -1,17 +1,8 @@
 import { MantineProvider } from "@mantine/core";
-import { useColorScheme, useLocalStorage } from "@mantine/hooks";
 import { Notifications } from "@mantine/notifications";
-
-// import ColorSchemeContext from "./ColorSchemeContext";
 import { Router } from "./Router";
-// import { UserResolverProvider } from "./components/NameOptionalCard";
 
 export default function App() {
-  // const preferredColorScheme = useColorScheme();
-  // const [colorScheme, setColorScheme] = useLocalStorage({
-  //   key: "acm-manage-color-scheme",
-  //   defaultValue: preferredColorScheme,
-  // });
   return (
     <MantineProvider>
       <Notifications position="top-right" />

src/common/utils/apiCache.ts

@@ -1,8 +1,3 @@
-/**
- * API Cache Utility
- * Provides caching with TTL (Time To Live) support to reduce unnecessary API calls
- */
-
 interface CacheEntry<T> {
   data: T;
   timestamp: number;
@@ -28,7 +23,6 @@ class ApiCache {
     const age = now - entry.timestamp;
 
     if (age > entry.ttl) {
-      // Cache expired, remove it
       this.cache.delete(key);
       return null;
     }
@@ -105,8 +99,8 @@ class ApiCache {
 export const apiCache = new ApiCache();
 
 export const CacheTTL = {
-  SHORT: 1 * 60 * 1000,      // 1 minute
-  MEDIUM: 5 * 60 * 1000,     // 5 minutes
-  LONG: 15 * 60 * 1000,      // 15 minutes
-  VERY_LONG: 60 * 60 * 1000, // 1 hour
+  SHORT: 1 * 60 * 1000,      
+  MEDIUM: 5 * 60 * 1000,     
+  LONG: 15 * 60 * 1000,      
+  VERY_LONG: 60 * 60 * 1000, 
 } as const;

src/components/Layout/Header.tsx

@@ -44,7 +44,7 @@ export function Header({ opened, toggle }: HeaderProps) {
         <Menu.Dropdown>
           <Menu.Label>My Account</Menu.Label>
           <Menu.Item leftSection={<IconUser style={{ width: rem(14), height: rem(14) }} />}
-          onClick={() => navigate("/profile", { replace: true })}
+            onClick={() => navigate("/profile", { replace: true })}
           >
             Profile
           </Menu.Item>

src/components/ProfileQR/index.tsx

@@ -1,7 +1,7 @@
 import { useEffect, useState } from 'react';
 import { Modal, Stack, Text, Loader, Center, Box, Button } from '@mantine/core';
 import QRCode from 'react-qr-code';
-import { useAuth } from '../AuthContext'; // Adjust path as needed
+import { useAuth } from '../AuthContext'; 
 import { IconAlertCircle } from '@tabler/icons-react';
 
 interface CheckInModalProps {
@@ -33,7 +33,6 @@ export function CheckInModal({ opened, onClose }: CheckInModalProps) {
       };
       fetchToken();
     } else {
-      // Security: Clear token when modal closes
       setToken(null);
       setError(null);
     }
@@ -53,7 +52,6 @@ export function CheckInModal({ opened, onClose }: CheckInModalProps) {
             <Loader size="xl" />
           </Center>
         ) : error ? (
-          // ❌ Replaced <Alert> with this Modal Error View
           <>
             <IconAlertCircle size={48} color="red" style={{ alignSelf: 'center' }} />
             <Text ta="center" fw={500}>Generation Failed</Text>
@@ -65,7 +63,6 @@ export function CheckInModal({ opened, onClose }: CheckInModalProps) {
             </Button>
           </>
         ) : token ? (
-          // ✅ Success View
           <>
             <Box p="md" bg="white" style={{ borderRadius: 8 }}>
               <QRCode 

src/pages/Login.page.tsx

@@ -32,10 +32,8 @@ export function LoginPage() {
           if (response.status === 400 || response.status === 404) {
             navigate("/profile?firstTime=true", { replace: true });
           } else if (response.ok) {
-            // Profile exists, redirect to returnTo or home
             navigate(returnTo || "/home", { replace: true });
           } else {
-            // Other errors, send to profile setup to be safe
             navigate("/profile?firstTime=true", { replace: true });
           }
         } catch (error) {

src/pages/events/UpcomingEvents.page.tsx

@@ -44,9 +44,7 @@ export function UpcomingEventsPage() {
     if (!response.ok) {
       const errData = await response.text();
 
-      // Handle specific error cases
       if (response.status === 400) {
-        // Check if it's a profile error
         if (errData.toLowerCase().includes('profile') || 
             errData.toLowerCase().includes('complete') ||
             errData.toLowerCase().includes('required')) {

src/pages/events/UpcomingEvents.view.tsx

@@ -75,15 +75,13 @@ export function UpcomingEventsView({ getEvents, onRsvp, onRefresh }: UpcomingEve
     try {
       await onRsvp(selectedEvent, token);
 
-      // Add to RSVPed events set
       setRsvpedEvents(prev => new Set(prev).add(selectedEvent.id));
 
       close();
 
     } catch (e: any) {
       console.error(e);
 
-      // Handle specific error cases
       if (e.message?.includes('400') || e.message?.toLowerCase().includes('profile')) {
         setRsvpError('profile');
       } else if (e.message?.toLowerCase().includes('full') || e.message?.toLowerCase().includes('capacity')) {
@@ -235,7 +233,6 @@ export function UpcomingEventsView({ getEvents, onRsvp, onRefresh }: UpcomingEve
         </SimpleGrid>
       )}
 
-      {/* RSVP Modal */}
       <Modal 
         opened={opened} 
         onClose={() => !rsvpLoading && close()} 

src/pages/profile/MyProfile.page.tsx

@@ -28,15 +28,13 @@ export function MyProfilePage() {
 
         if (!response.ok) {
           if (response.status === 404) {
-            // Profile doesn't exist yet - redirect to first-time setup if not already there
             if (!isFirstTime) {
               navigate("/profile?firstTime=true", { replace: true });
             }
             return null;
           }
 
           if (response.status === 400) {
-            // Validation error or incomplete profile
             const errData = await response.text();
             console.error('Profile validation error:', errData);
             if (!isFirstTime) {
@@ -50,7 +48,7 @@ export function MyProfilePage() {
 
         return await response.json();
       },
-      CacheTTL.MEDIUM // Cache for 5 minutes
+      CacheTTL.MEDIUM 
     );
   }, [getToken, navigate, isFirstTime]);
 

src/pages/profile/MyProfile.view.tsx

@@ -12,29 +12,14 @@ import {
   IconSchool, IconStar, IconApple, IconQrcode 
 } from '@tabler/icons-react';
 import { config } from '../../config';
-import { RsvpProfile } from '../../common/types/rsvp';
+import { RsvpProfile, SCHOOL_YEARS, MAJORS, COMMON_INTERESTS } from '../../common/types/rsvp';
 import { CheckInModal } from '../../components/ProfileQR';
 
 interface MyProfileViewProps {
   getProfile: () => Promise<RsvpProfile | null>;
   updateProfile: (profile: Omit<RsvpProfile, 'updatedAt'>, turnstileToken: string) => Promise<void>;
   isFirstTime: boolean;
 }
-
-const SCHOOL_YEARS = ["Freshman", "Sophomore", "Junior", "Senior", "Graduate"];
-
-// ... (Keep MAJORS, COMMON_INTERESTS, and DIETARY_RESTRICTIONS_OPTIONS arrays exactly as they were) ...
-const MAJORS = [
-  "ACES Undeclared", "Accountancy", "Computer Science", "Electrical Engineering", "Mechanical Engineering", 
-  // ... (Abbreviated for brevity, keep your full list) ...
-  "Other"
-];
-
-const COMMON_INTERESTS = [
-  "AI/Machine Learning", "Web Development", "Mobile Development", "Cybersecurity", "Game Development",
-  "Data Science", "Cloud Computing", "Robotics", "Blockchain", "UI/UX Design"
-];
-
 const DIETARY_RESTRICTIONS_OPTIONS = [
   "Vegetarian", "Vegan", "Gluten-Free", "Dairy-Free", "Nut Allergy", "Shellfish Allergy", "Halal", "Kosher", "Lactose Intolerant", "Pescatarian"
 ];
@@ -46,19 +31,16 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
   const [error, setError] = useState<string | null>(null);
   const [isEditing, setIsEditing] = useState(isFirstTime);
 
-  // Form state
   const [schoolYear, setSchoolYear] = useState<string>('');
   const [intendedMajor, setIntendedMajor] = useState<string>('');
   const [interests, setInterests] = useState<string[]>([]);
   const [dietaryRestrictions, setDietaryRestrictions] = useState<string[]>([]);
   const [customInterest, setCustomInterest] = useState('');
 
-  // Modal and turnstile state
   const [opened, { open, close }] = useDisclosure(false);
   const [welcomeOpened, { open: openWelcome, close: closeWelcome }] = useDisclosure(isFirstTime);
   const [saveLoading, setSaveLoading] = useState(false);
 
-  // QR Modal State
   const [qrModalOpened, { open: openQrModal, close: closeQrModal }] = useDisclosure(false);
 
   useEffect(() => {
@@ -76,7 +58,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
         setDietaryRestrictions(data.dietaryRestrictions);
         setError(null);
       } else if (!isFirstTime) {
-        // Explicitly set error if no data found and not in setup mode
         setError("Profile not found.");
       }
     } catch (err: any) {
@@ -165,7 +146,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
     return Math.round((completed / total) * 100);
   };
 
-  // 1. Critical Error State: If not loading, not first time, and no profile
   if (!loading && !isFirstTime && !profile) {
     return (
       <Container size="md" py="xl">
@@ -186,7 +166,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
 
   return (
     <Container size="md" py="xl">
-      {/* 2. QR Code Modal Component */}
       <CheckInModal opened={qrModalOpened} onClose={closeQrModal} />
 
       <Stack gap="lg">
@@ -196,7 +175,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
             <Text c="dimmed" size="sm">Manage your personal information and preferences</Text>
           </Box>
 
-          {/* 3. Header Actions (Edit & QR) */}
           {!isEditing && profile && (
             <Group gap="xs">
                <Button 
@@ -242,7 +220,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
             <Stack gap="md">
               {isEditing ? (
                 <>
-                  {/* ... (Keep existing Editing Form JSX exactly as is) ... */}
                   <Select
                     label={<Group gap="xs"><IconSchool size={16} /><Text size="sm" fw={500}>School Year</Text></Group>}
                     placeholder="Select your year"
@@ -308,7 +285,6 @@ export function MyProfileView({ getProfile, updateProfile, isFirstTime }: MyProf
                 </>
               ) : (
                 <>
-                  {/* ... (Keep existing View Mode JSX exactly as is) ... */}
                   <Box>
                     <Group gap="xs" mb={4}>
                       <IconSchool size={16} stroke={1.5} />

src/pages/rsvps/MyRsvps.page.tsx

@@ -21,7 +21,6 @@ export function MyRsvpsPage() {
         const token = await getToken();
         if (!token) throw new Error("Unable to authenticate.");
 
-        // Fetch RSVPs and events in parallel
         const [rsvpRes, eventsRes] = await Promise.all([
           fetch(config.apiBaseUrl + '/api/v1/rsvp/me', {
             headers: { 
@@ -78,7 +77,7 @@ export function MyRsvpsPage() {
         }).sort((a, b) => {
           const dateA = a.startTime ? new Date(a.startTime).getTime() : 0;
           const dateB = b.startTime ? new Date(b.startTime).getTime() : 0;
-          return dateB - dateA; // Most recent/upcoming first
+          return dateB - dateA; 
         });
       },
       CacheTTL.MEDIUM 
@@ -104,7 +103,6 @@ export function MyRsvpsPage() {
     if (!response.ok) {
       const txt = await response.text();
 
-      // Handle specific error cases
       if (response.status === 404) {
         throw new Error('RSVP not found. It may have already been cancelled.');
       }
@@ -116,9 +114,8 @@ export function MyRsvpsPage() {
       throw new Error(txt || 'Failed to cancel RSVP');
     }
 
-    // Invalidate caches after successful cancellation
     apiCache.invalidate('rsvps:my');
-    apiCache.invalidate('events:upcoming'); // Event capacity may have changed
+    apiCache.invalidate('events:upcoming'); 
   }, [getToken]);
 
   return (