Skip to content

Commit c3219fb

Browse files
dmerrickclaude
andauthored
Mark bump-prs commits/titles #none so they don't fire releases (#851)
Bump PRs target master, where auto-tag.yml mints a tag and triggers release.yml on every push. A pin edit is a deploy gesture, not a release, so each merged bump was minting a spurious release. Add #none (honored by anothrNick/github-tag-action) to both the commit message and the PR title so the skip-tag marker survives whether the PR is merge-committed or squash-merged. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 6406e2b commit c3219fb

1 file changed

Lines changed: 13 additions & 2 deletions

File tree

.github/workflows/bump-prs.yml

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ name: bump-prs
77
# it now edits THIS repo's cdk8s/versions.yaml and the PRs target `master`
88
# (the prod-tracking branch — prod-1 pins float to master, stage rides develop).
99
#
10+
# Bump PRs are deploy gestures, not releases: both the commit message and the PR
11+
# title carry `#none` so auto-tag.yml skips the version bump when they land on
12+
# master. Without it, every merged pin edit would mint a tag and fire release.yml.
13+
#
1014
# Fired by this repo's release workflow (workflow_dispatch with the released
1115
# version) or by hand. Each component leg:
1216
#
@@ -141,15 +145,22 @@ jobs:
141145
git config user.name "github-actions[bot]"
142146
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
143147
git add cdk8s/versions.yaml cdk8s/dist/
144-
git commit -m "Bump prod $COMPONENT to $VERSION"
148+
# `#none` tells auto-tag.yml (anothrNick/github-tag-action) to skip the
149+
# version bump when this lands on master. Bump PRs are deploy gestures,
150+
# not releases — without this each merged bump would mint a new tag and
151+
# fire release.yml, spamming releases off a pin edit.
152+
git commit -m "Bump prod $COMPONENT to $VERSION #none"
145153
git push -f origin "$BRANCH"
146154
147155
- name: Create or refresh the bump PR
148156
if: env.CURRENT != env.VERSION
149157
env:
150158
GH_TOKEN: ${{ steps.app-token.outputs.token }}
151159
run: |
152-
TITLE="Bump prod $COMPONENT to $VERSION"
160+
# `#none` in the title too (not just the commit) so the skip-tag
161+
# marker survives a squash-merge, where GitHub derives the commit
162+
# subject from the PR title.
163+
TITLE="Bump prod $COMPONENT to $VERSION #none"
153164
case "$COMPONENT" in
154165
obs) IMPACT="⚠️ **Merging restarts the OBS pod — the stream goes down until it reconnects.** Pick a quiet moment." ;;
155166
vlc) IMPACT="⚠️ **Merging restarts vlc-server — the playing video drops briefly on stream.** Pick a quiet moment." ;;

0 commit comments

Comments
 (0)