Skip to content

Commit 02091d0

Browse files
committed
Revert "use title attr on emojis"
This reverts commit 6e459ec.
1 parent 6e459ec commit 02091d0

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

adbc_drivers_validation/generate_documentation.py

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@
3131

3232
from . import model
3333

34-
LABEL_SUPPORTED = '<span title="Supported">✅</span>'
35-
LABEL_PARTIALLY_SUPPORTED = '<span title="Partially Supported">⚠️</span>'
36-
LABEL_UNSUSPPORTED = '<span title="Unsupported">❌</span>'
37-
3834

3935
@dataclasses.dataclass
4036
class CustomFeature:
@@ -89,31 +85,31 @@ def pprint(self) -> str:
8985

9086
value = getattr(self.features, field.name)
9187
if isinstance(value, bool):
92-
value = LABEL_SUPPORTED if value else LABEL_UNSUSPPORTED
88+
value = "✅" if value else "❌"
9389
lines.append(f"- {field.name}: {value}")
9490

9591
for group, features in self.custom_features.groups.items():
9692
lines.append(f"- {group}:")
9793
for feature in features:
98-
status = LABEL_SUPPORTED if feature.supported else LABEL_UNSUSPPORTED
94+
status = "✅" if feature.supported else "❌"
9995
lines.append(f" - {feature.name}: {status} {feature.description}")
10096

10197
lines.append("")
10298
lines.append("GetObjects")
10399
lines.append("~~~~~~~~~~")
104100
for name, supported in self.get_objects.items():
105-
status = LABEL_SUPPORTED if supported else LABEL_UNSUSPPORTED
101+
status = "✅" if supported else "❌"
106102
lines.append(f"- {name}: {status}")
107103

108-
status = LABEL_SUPPORTED if self.get_table_schema else LABEL_UNSUSPPORTED
104+
status = "✅" if self.get_table_schema else "❌"
109105
lines.append("")
110106
lines.append(f"GetTableSchema: {status}")
111107

112108
lines.append("")
113109
lines.append("Ingest Modes")
114110
lines.append("~~~~~~~~~~~~")
115111
for name, supported in self.ingest.items():
116-
status = LABEL_SUPPORTED if supported else LABEL_UNSUSPPORTED
112+
status = "✅" if supported else "❌"
117113
lines.append(f"- {name}: {status}")
118114

119115
def render_type_table(category: str, entries: list[tuple[str, str]]) -> None:
@@ -201,11 +197,11 @@ def add_table_entry(
201197
caveats.append(caveat)
202198

203199
if passed == 0:
204-
table_entry = LABEL_UNSUSPPORTED
200+
table_entry = "❌"
205201
elif (
206202
partial_support or passed < len(test_case["test_results"]) or extra_caveats
207203
):
208-
table_entry += f" {LABEL_PARTIALLY_SUPPORTED}"
204+
table_entry += " ⚠️"
209205
for query_name, result in zip(
210206
test_case["query_names"], test_case["test_results"]
211207
):

0 commit comments

Comments
 (0)