Skip to content

Commit b3e588d

Browse files
authored
fix: sort and deduplicate versions tested (#258)
1 parent 61d34f9 commit b3e588d

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

adbc_drivers_validation/generate_documentation.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -861,10 +861,13 @@ def render(
861861
)
862862

863863
compatibility_info = "This driver was tested on:\n"
864-
for version in sorted(report.versions, key=lambda v: (v.vendor, v.version)):
864+
# Sort and deduplicate by the rendered string not by dev-facing identifier
865+
compat_versions = set()
866+
for version in report.versions:
865867
vendor_name = report.versions[version].quirks.vendor_name
866868
full_version = report.versions[version].vendor_version
867-
compatibility_info += f"\n- {vendor_name} `{full_version}`"
869+
compat_versions.add(f"\n- {vendor_name} `{full_version}`")
870+
compatibility_info += "\n".join(sorted(compat_versions))
868871

869872
if is_prerelease:
870873
heading += (

adbc_drivers_validation/tests/query.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,7 @@ def test_query(
154154

155155
with conn.cursor() as cursor:
156156
with driver.setup_statement(query, cursor):
157-
with scoped_trace(f"query: {sql}"):
158-
result = execute_query_without_prepare(cursor, sql)
157+
result = execute_query_without_prepare(cursor, sql)
159158

160159
compare.compare_tables(expected_result, result, query.metadata())
161160
utils.assert_field_type_name(driver, "query", query, result.schema)

0 commit comments

Comments
 (0)