refactor: extract some utilities (#161)

Closes #160.

Co-authored-by: Claude <noreply@anthropic.com>

Author: lidavidm

adbc_drivers_validation/model.py

@@ -261,6 +261,51 @@ def drop_table(
         else:
             return f"DROP TABLE {name}"
 
+    def try_drop_table(
+        self,
+        cursor: adbc_driver_manager.dbapi.Cursor,
+        *,
+        table_name: str,
+        schema_name: str | None = None,
+        catalog_name: str | None = None,
+        temporary: bool = False,
+    ) -> None:
+        """
+        Try to drop a table, ignoring errors if the table does not exist.
+
+        Some databases have no way to do DROP IF EXISTS, so this method
+        attempts to drop the table and catches errors that indicate the
+        table was not found.
+
+        Parameters
+        ----------
+        cursor : adbc_driver_manager.dbapi.Cursor
+            The cursor to execute the query.
+        table_name : str
+            The name of the table to drop.
+        schema_name : str, optional
+            The schema containing the table (if not given, assume current
+            schema).
+        catalog_name : str, optional
+            The catalog containing the table (if not given, assume current
+            catalog).
+        temporary : bool
+            If True, the table is a temporary table.
+        """
+        try:
+            cursor.execute(
+                self.drop_table(
+                    table_name=table_name,
+                    schema_name=schema_name,
+                    catalog_name=catalog_name,
+                    temporary=temporary,
+                )
+            )
+        except adbc_driver_manager.Error as e:
+            # Some databases have no way to do DROP IF EXISTS
+            if not self.is_table_not_found(table_name=table_name, error=e):
+                raise
+
     @abc.abstractmethod
     def is_table_not_found(self, table_name: str | None, error: Exception) -> bool:
         """

adbc_drivers_validation/tests/connection.py

@@ -266,11 +266,7 @@ def test_get_objects_table_not_exist(
         # parts of it
         table_name = "getobjectstest2"
         with conn.cursor() as cursor:
-            try:
-                cursor.execute(driver.drop_table(table_name=table_name))
-            except adbc_driver_manager.Error as e:
-                if not driver.is_table_not_found(table_name=table_name, error=e):
-                    raise
+            driver.try_drop_table(cursor, table_name=table_name)
 
         objects = conn.adbc_get_objects(depth="tables").read_all().to_pylist()
         tables = [
@@ -688,24 +684,14 @@ def get_objects_table(
                 table_name,
             )
             with conn.cursor() as cursor:
-                try:
-                    cursor.execute(driver.drop_table(table_name=table_name))
-                except adbc_driver_manager.Error as e:
-                    # Some databases have no way to do DROP IF EXISTS
-                    if not driver.is_table_not_found(table_name=None, error=e):
-                        raise
+                driver.try_drop_table(cursor, table_name=table_name)
 
                 cursor.adbc_ingest(table_name, data)
 
             yield table_id
 
             with conn.cursor() as cursor:
-                try:
-                    cursor.execute(driver.drop_table(table_name=table_name))
-                except adbc_driver_manager.Error as e:
-                    # Some databases have no way to do DROP IF EXISTS
-                    if not driver.is_table_not_found(table_name=None, error=e):
-                        raise
+                driver.try_drop_table(cursor, table_name=table_name)
 
     @pytest.fixture(scope="class")
     def get_objects_constraints(