feat: account for vendors that don't support bind parameters (#22)

Author: lidavidm

adbc_drivers_validation/model.py

@@ -85,6 +85,7 @@ class DriverFeatures:
     get_objects_constraints_foreign: bool = False
     get_objects_constraints_primary: bool = False
     get_objects_constraints_unique: bool = False
+    statement_bind: bool = True
     statement_bulk_ingest: bool = False
     statement_bulk_ingest_catalog: bool = False
     statement_bulk_ingest_schema: bool = False

adbc_drivers_validation/tests/conftest.py

@@ -22,8 +22,12 @@
 
 from adbc_drivers_validation import model
 
-# Rewrite assertions in this module to have the friendly display
+# Rewrite assertions in these modules to have the friendly display
 pytest.register_assert_rewrite("adbc_drivers_validation.compare")
+pytest.register_assert_rewrite("adbc_drivers_validation.tests.connection")
+pytest.register_assert_rewrite("adbc_drivers_validation.tests.ingest")
+pytest.register_assert_rewrite("adbc_drivers_validation.tests.query")
+pytest.register_assert_rewrite("adbc_drivers_validation.tests.statement")
 
 
 def pytest_collection_modifyitems(

adbc_drivers_validation/tests/ingest.py

@@ -35,7 +35,7 @@ def generate_tests(quirks: model.DriverQuirks, metafunc) -> None:
     combinations = []
 
     enabled = {
-        "test_not_null": True,
+        "test_not_null": quirks.features.statement_bulk_ingest,
         "test_temporary": quirks.features.statement_bulk_ingest_temporary,
         "test_schema": quirks.features.statement_bulk_ingest_schema,
         "test_catalog": quirks.features.statement_bulk_ingest_catalog,

adbc_drivers_validation/tests/query.py

@@ -35,6 +35,14 @@ def generate_tests(quirks: model.DriverQuirks, metafunc) -> None:
     for query in queries.queries.values():
         marks = []
         marks.extend(query.pytest_marks)
+
+        if (
+            not quirks.features.statement_bind
+            and isinstance(query.query, model.SelectQuery)
+            and query.query.bind_query(quirks) is not None
+        ):
+            marks.append(pytest.mark.skip(reason="bind not supported"))
+
         if metafunc.definition.name == "test_execute_schema":
             if not isinstance(query.query, model.SelectQuery):
                 continue

adbc_drivers_validation/tests/statement.py

@@ -32,14 +32,20 @@ def generate_tests(quirks: model.DriverQuirks, metafunc) -> None:
     combinations = []
 
     if (
-        metafunc.definition.name == "test_parameter_schema"
-        and not quirks.features.statement_get_parameter_schema
+        metafunc.definition.name == "test_parameter_execute"
+        and not quirks.features.statement_bind
     ):
-        marks.append(
-            pytest.mark.xfail(
-                raises=adbc_driver_manager.dbapi.NotSupportedError, strict=True
+        marks.append(pytest.mark.skip("bind not supported"))
+
+    if metafunc.definition.name == "test_parameter_schema":
+        if not quirks.features.statement_bind:
+            marks.append(pytest.mark.skip("bind not supported"))
+        elif not quirks.features.statement_get_parameter_schema:
+            marks.append(
+                pytest.mark.xfail(
+                    raises=adbc_driver_manager.dbapi.NotSupportedError, strict=True
+                )
             )
-        )
 
     if (
         metafunc.definition.name == "test_prepare"