The app can not be initialised when the local storage value is invalid

[gedaiu]

It looks like if the stored value can't be parsed, an error is thrown and the default value will not be set.

[fsmanuel]

Hey @gedaiu, do you have an example of the data?

[gedaiu]

you can reproduce it with any string that is not a json. You can try with something like this:

[{]}

or with a random string

asdfg

I think the problem is that the deserialization code assumes that the stored data is always valid.

[fsmanuel]

What could be the right behavior if the deserialization doesn't work? Reset it to the initial data?

[gedaiu]

I'm not sure... right now, I do something like this when I start the app:

    try {
      JSON.parse(window.localStorage.getItem("storage:pending-data"));
    } catch(err) {
      window.localStorage.removeItem("storage:pending-data")
      // eslint-disable-next-line no-console
      console.log("the local storage is corrupted: ", err);
     }

but for me, it's not that critical if this data is lost.

i'm thinking that ideally, it would be nice to have something like this:

Storage.reopenClass({
  initialState() {
    return {
      lastKnownValue: null
    };
  },
  recoverState(stringValue) {
     /// ... do something here or just
     return this.initialState();
  }
});

or allow the Storage object to serialize/deserialize the data, and handle the errors if there are any... just like ember transforms.

I am not sure how other people use this library, but I am fine with either solution.