Skip to content

PeerDependency @ember/string is missing #380

Description

@mkszepp

The addon is using @ember/string but its not declared as peerDependency.

This makes impossible to use @ember/string v4 as its a v2 addon

https://github.com/funkensturm/ember-local-storage/blob/02112d14e475520a776f3eb97ef4bf918e10fd79/addon/helpers/storage.js#L1-L8

There are two options to fix this issue:

  • adding dasherize as internal function (not braking - recommended)
  • adding @ember/string as peerDependency (braking)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions