linux libfreetype dependencies broken in jdk 8-20

[lobachpavel]

Hi

After this commit to temurin-build newer JDK 8-20 deb package builds have broken libfreetype dependency in libfontmanager.so

Example for package temurin-17-jdk 17.0.18.0.0+8-0 (installed in Ubuntu 22.04):

# ldd /usr/lib/jvm/temurin-17-jdk-amd64/lib/libfontmanager.so
	libfreetype.so => not found
	libawt.so => /usr/lib/jvm/temurin-17-jdk-amd64/lib/libawt.so (0x00007fffff52e000)
	libjava.so => /usr/lib/jvm/temurin-17-jdk-amd64/lib/libjava.so (0x00007fffff504000)
	libjvm.so => /usr/lib/jvm/temurin-17-jdk-amd64/lib/server/libjvm.so (0x00007ffffe1b2000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007ffffe0cb000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007ffffdea2000)
	/lib64/ld-linux-x86-64.so.2 (0x00007ffffffc4000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007ffffde9b000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007ffffde96000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007ffffde91000)

the reason is that deb rules for versions < 21 contain command to exclude the bundled libfreetype.so (see example for jdk17), but above commit to temurin-build states that All build-configs should use default (bundeld) free type, so we expect libfreetype.so to be included in all jdk deb packages, but this is true only for jdk versions 21+.

In the past the very same problem was fixed for jdk 21 in #812
Please make similar changes for jdk 8-20

[judovana]

hi!

So you suggest to apply https://github.com/adoptium/installer/pull/812/files like approach to 8-20, right?

Sorry for overlooking it when workign on bundled freetype.

[lobachpavel]

So you suggest to apply https://github.com/adoptium/installer/pull/812/files like approach to 8-20, right?

Correct

[judovana]

It seems that thee rm -f of libfreetype was left also in specfiles. Thanx a lot for report. Fixing.

[karianna]

@steelhead31 does #1319 close this?

[steelhead31]

@karianna Yes, this has now been resolved, packages produced as part of the January release cycle, will have this fix in place.

[lobachpavel]

Hi

Thanks for the fix. One more question: do we still need libfreetype dependency in the deb control files?
rpm spec files do not have it anymore…

[steelhead31]

@lobachpavel the debian rules files now have it removed, but it is still present in the control files, I'll take a look into this

[steelhead31]

I think the dependency being listed in the control files is ok, as it ensures the system version of freetype is present( and it is required ), rather than using the one bundled with the jdk as previously. Let me know if having that dependency causes any issues though.

[lobachpavel]

Hmm. Still it’s not clear to me:

The whole point of the fix was to start using bundled libfreetype, right? Why do we still need the system one then?

Also, if you look into #1319 - it removes system deps from rpm spec files, but not from deb control files. To me it must be symmetrical change. Either we need system libfreetype dep in both rpm and deb or we don’t need it at all.