Modernized README.md for wix, removed localization in URLs - #1458
Merged
Conversation
jmjaffe37
marked this pull request as draft
August 28, 2026 18:20
jmjaffe37
marked this pull request as ready for review
August 28, 2026 18:20
joe-braley
approved these changes
Aug 28, 2026
karianna
approved these changes
Aug 28, 2026
Contributor
|
Weird that 25 and 8 pass but not the other 3. @jmjaffe37 is that expected? |
Contributor
Author
|
@karianna, I did not look into the issue, but I saw that they failed within a minute, so I assume that it was a transient issue on the side of the runners/agents. I would imagine that running these again will result in success, but I do not seem to have permissions to rerun those tests. Alos, since this change only effects the readme, it should be fine to merge either way |
jmjaffe37
changed the title
Contributor
|
@jmjaffe37 It continued to fail on repeated runs: Copilot thinks the fix should be as per https://github.com/adoptium/installer/pull/1460/changes - I think that's correct given we've just had the version change to add the extra number but would appreciate your expert eye. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed both 'fr-fr' and 'en-us' localization strings from URLs, removed references to windows 10, and modernized the URLs (docs.microsoft.com -> learn.microsoft.com)