V48 Gate 3: Fix Setup iter badge; serial Discovery

geraldarthurdavis · geraldarthurdavis · commit 25e1a8daef1a · 2026-07-19T13:43:21.000-07:00
DIV iter must not paint on Setup formal rows (late dual-write after
currentIteration=1). Default Discovery wave-1 to serial and pin
BITCODE_DEBUG_DISCOVERY_SERIAL + Node heap for sandbox product hosts
to avoid exit 137 after Setup on large monorepos.
diff --git a/apps/uapi/components/bitcode/pipeline/models/pipeline-run-activity.ts b/apps/uapi/components/bitcode/pipeline/models/pipeline-run-activity.ts
@@ -219,16 +219,40 @@ function updateRollingContext(ctx: ExecContext, payload: any): void {
   if (payload?.type === 'phase' && payload?.phase) ctx.phase = String(payload.phase);
   if (payload?.type === 'agent' && payload?.agent) ctx.agent = String(payload.agent);
 
-  // DIV-loop iteration (1-based): the SDIVF executor variant stores
-  // phase/iteration at each observed D/I/V phase start; the classic variant
-  // stores pipeline/currentIteration at the top of each pass. Setup precedes
-  // the first store and Finish runs outside the loop, so clear the latch once
-  // the finish phase starts.
+  // DIV-loop iteration (1-based): the SDIVF executor stores
+  // pipeline/currentIteration when the DIV loop starts (just before Discovery),
+  // and phase/iteration on D/I/V phase starts. Setup/Finish rows must not show
+  // "iter N" — that is enforced in iterationForPhase when stamping formal rows
+  // (not by clearing the latch here: currentIteration is written while phase
+  // is still "setup" for a beat, and clearing would drop iter before Discovery).
   if ((ns === 'phase' && key === 'iteration') || (ns === 'pipeline' && key === 'currentIteration')) {
     const iteration = Number(value);
     if (Number.isFinite(iteration) && iteration > 0) ctx.iteration = iteration;
   }
-  if (String(ctx.phase || '').toLowerCase().includes('finish')) ctx.iteration = null;
+  if (String(ctx.phase || '').toLowerCase().includes('finish')) {
+    ctx.iteration = null;
+  }
+}
+
+/** DIV-loop phases only — Setup/Finish must never carry an iteration badge. */
+function iterationForPhase(
+  phase: string | null | undefined,
+  rollingIteration: number | null | undefined,
+): number | null {
+  const p = String(phase || '').toLowerCase();
+  if (!p || p.includes('setup') || p.includes('finish')) return null;
+  const inDiv =
+    p.includes('discovery') ||
+    p.includes('implementation') ||
+    p.includes('validation') ||
+    // short product labels sometimes omit the full phase name
+    p === 'd' ||
+    p === 'i' ||
+    p === 'v';
+  if (!inDiv) return null;
+  return typeof rollingIteration === 'number' && rollingIteration > 0
+    ? rollingIteration
+    : null;
 }
 
 type FormalLogLineKind = 'llm' | 'tool';
@@ -432,13 +456,17 @@ export function buildPipelineRunActivityFromEvents(
       // The LLM call carries the full hierarchy itself; fall back to the rolling
       // context only for any field the event omits.
       const own = readEventExecutionState(payload);
+      const phase = own.phase ?? rollingContext.phase ?? null;
       const merged: ExecContext = {
-        phase: own.phase ?? rollingContext.phase ?? null,
+        phase,
         agent: own.agent ?? rollingContext.agent ?? null,
         step: own.step ?? rollingContext.step ?? null,
         failsafe: own.failsafe ?? null,
         generation: own.generation ?? null,
-        iteration: rollingContext.iteration ?? null,
+        // Never stamp DIV iter onto Setup rows (late dual-write after
+        // currentIteration=1 at Discovery start used to paint "iter 1" on the
+        // last Setup refine STRUCTURE line).
+        iteration: iterationForPhase(phase, rollingContext.iteration),
       };
       const text = String(payload?.message || payload?.status?.message || '[content withheld — source-safe]');
       pushRow(text, stampExecutionState(merged, { ...payload, type: 'generation' }, deriveFailsafeRepairMarkers(payload)));
@@ -463,11 +491,12 @@ export function buildPipelineRunActivityFromEvents(
         payload?.metadata?.toolName ||
         (key === 'error' ? 'tool (failed)' : 'tool');
       // Tool uses have Phase/Agent/Step but no Failsafe/Thinkings.
+      const phase = rollingContext.phase ?? null;
       const merged: ExecContext = {
-        phase: rollingContext.phase ?? null,
+        phase,
         agent: rollingContext.agent ?? null,
         step: rollingContext.step ?? null,
-        iteration: rollingContext.iteration ?? null,
+        iteration: iterationForPhase(phase, rollingContext.iteration),
       };
       const enriched = stampExecutionState(merged, { ...payload, type: 'tool-use' }, { tool: toolName });
       enriched.metadata = {
diff --git a/apps/uapi/lib/pipeline-host-command-env.ts b/apps/uapi/lib/pipeline-host-command-env.ts
@@ -90,6 +90,26 @@ export function selectedPipelineHostCommandEnvironment(
   // left execution_events as status-only spam and the UI showed "No logs
   // available" despite healthy Setup/Discovery (run 793f8be1).
   env.BITCODE_PIPELINE_LEGACY_EVENTS_DB = '1';
+  // Cap the in-box Node heap so Discovery on large monorepos fails more
+  // gracefully (and sooner) than an unbounded V8 growth + host SIGKILL.
+  // Child language servers use BITCODE_LSP_MAX_OLD_SPACE_MB separately.
+  const pipelineHeapMb = (() => {
+    const raw = Number(process.env.BITCODE_PIPELINE_MAX_OLD_SPACE_MB);
+    if (Number.isFinite(raw) && raw >= 512 && raw <= 4096) return Math.floor(raw);
+    return 1536;
+  })();
+  const parentNodeOptions = String(process.env.NODE_OPTIONS || '');
+  env.NODE_OPTIONS = [
+    parentNodeOptions.replace(/--max-old-space-size=\d+/g, '').trim(),
+    `--max-old-space-size=${pipelineHeapMb}`,
+  ]
+    .filter(Boolean)
+    .join(' ');
+  // Prefer serial Discovery wave-1 inside the box even on older images that
+  // still default parallel (set before image rebuild lands).
+  if (!env.BITCODE_DEBUG_DISCOVERY_SERIAL && !process.env.BITCODE_DEBUG_DISCOVERY_PARALLEL) {
+    env.BITCODE_DEBUG_DISCOVERY_SERIAL = '1';
+  }
   // Inference is owned by the host/Pipeliner process. Product default is on
   // when unset; honor explicit opt-out (0/false/off) for unit tests.
   const realInferenceRaw = process.env.BITCODE_ASSET_PACK_REAL_INFERENCE;
diff --git a/apps/uapi/tests/lib/depositSourceProvisioning.test.ts b/apps/uapi/tests/lib/depositSourceProvisioning.test.ts
@@ -319,9 +319,13 @@ describe('runDepositInBoxHost (#25)', () => {
       BITCODE_PIPELINE_STREAM_TO_DATABASE: '1',
       BITCODE_PIPELINE_STRUCTURED_DB: '1',
       BITCODE_PIPELINE_LEGACY_EVENTS_DB: '1',
+      BITCODE_DEBUG_DISCOVERY_SERIAL: '1',
       BITCODE_PIPELINE_USER_ID: 'user-deposit-test',
       BITCODE_PIPELINE_RUN_ID: 'run-deposit-test',
     });
+    expect(receivedPlan.createOptions.env.NODE_OPTIONS || '').toMatch(
+      /max-old-space-size=/,
+    );
     expect(receivedPlan.manifest.sourceRevision).toMatchObject({
       branch: 'main',
       commit: 'abc123def456',
diff --git a/apps/uapi/tests/pipelineExecutionLogTelemetryUx.test.tsx b/apps/uapi/tests/pipelineExecutionLogTelemetryUx.test.tsx
@@ -286,6 +286,88 @@ describe('buildPipelineRunActivityFromEvents — mode latch + latest context', (
     const snapshot = buildPipelineRunActivityFromEvents(duped, null, [], null);
     expect(Object.keys(snapshot.outputDetails)).toHaveLength(1);
   });
+
+  it('never stamps DIV iter on Setup formal rows even after currentIteration=1', () => {
+    // Late dual-write: Setup refine STRUCTURE after Discovery latched iter 1
+    // used to paint "iter 1" on the last Setup log line (run 9d8bcf0f UX).
+    const mixed = [
+      {
+        id: 's1',
+        event: {
+          type: 'generation',
+          namespace: 'llm',
+          key: 'output',
+          message: '[content withheld — source-safe]',
+          executionState: {
+            phase: 'setup',
+            agent: 'DepositInputComprehensionAgent',
+            step: 'refine',
+            failsafe: 'prepare_concise_context',
+            generation: 'reason',
+          },
+        },
+        created_at: '2026-07-01T00:00:01.000Z',
+      },
+      {
+        id: 'iter',
+        event: {
+          type: 'status',
+          namespace: 'pipeline',
+          key: 'currentIteration',
+          data: 1,
+        },
+        created_at: '2026-07-01T00:00:02.000Z',
+      },
+      {
+        id: 's2-late',
+        event: {
+          type: 'generation',
+          namespace: 'llm',
+          key: 'output',
+          message: '[content withheld — source-safe]',
+          executionState: {
+            phase: 'setup',
+            agent: 'DepositInputComprehensionAgent',
+            step: 'refine',
+            failsafe: 'handle_prompts',
+            generation: 'structured_output',
+          },
+        },
+        created_at: '2026-07-01T00:00:03.000Z',
+      },
+      {
+        id: 'd1',
+        event: {
+          type: 'generation',
+          namespace: 'llm',
+          key: 'output',
+          message: '[content withheld — source-safe]',
+          executionState: {
+            phase: 'discovery',
+            agent: 'DepositCodebaseComprehensionAgent',
+            step: 'plan',
+            failsafe: 'prepare_concise_context',
+            generation: 'reason',
+          },
+        },
+        created_at: '2026-07-01T00:00:04.000Z',
+      },
+    ];
+    const snapshot = buildPipelineRunActivityFromEvents(mixed, null, [], null);
+    const rows = Object.values(snapshot.outputDetails) as any[];
+    const setupRows = rows.filter((r) =>
+      String(r?.executionState?.phase || '').toLowerCase().includes('setup'),
+    );
+    const discoveryRows = rows.filter((r) =>
+      String(r?.executionState?.phase || '').toLowerCase().includes('discovery'),
+    );
+    expect(setupRows.length).toBe(2);
+    for (const row of setupRows) {
+      expect(row.executionState.iteration ?? null).toBeNull();
+    }
+    expect(discoveryRows.length).toBe(1);
+    expect(discoveryRows[0].executionState.iteration).toBe(1);
+  });
 });
 
 // ---------------------------------------------------------------------------
diff --git a/packages/asset-packs-pipelines/syntheses/deposit/src/phases/execution-pipeline-sdivf-execution-phase-discovery-synthesis-deposit-asset-packs.ts b/packages/asset-packs-pipelines/syntheses/deposit/src/phases/execution-pipeline-sdivf-execution-phase-discovery-synthesis-deposit-asset-packs.ts
@@ -145,15 +145,33 @@ export const executionPipelineSDIVFExecutionPhaseDiscoverySynthesisDepositAssetP
     );
   }
 
-  const serialDiscovery =
-    String(process.env.BITCODE_DEBUG_DISCOVERY_SERIAL || '').toLowerCase() ===
-      '1' ||
-    String(process.env.BITCODE_DEBUG_DISCOVERY_SERIAL || '').toLowerCase() ===
-      'true' ||
-    String(process.env.BITCODE_DEBUG_SETUP_SERIAL || '').toLowerCase() ===
-      '1' ||
-    String(process.env.BITCODE_DEBUG_SETUP_SERIAL || '').toLowerCase() ===
-      'true';
+  // Product default: serial wave-1 Discovery. Parallel comprehend-codebase ∥
+  // inherent-regurgitation OOM-killed the sandbox (exit 137) on Bitcode monorepo
+  // right after Setup closed (run 9d8bcf0f). Opt into parallel only with
+  // BITCODE_DEBUG_DISCOVERY_PARALLEL=1 on small checkouts.
+  const forceParallel =
+    ['1', 'true', 'yes', 'on'].includes(
+      String(process.env.BITCODE_DEBUG_DISCOVERY_PARALLEL || '')
+        .trim()
+        .toLowerCase(),
+    );
+  const forceSerial =
+    ['1', 'true', 'yes', 'on'].includes(
+      String(process.env.BITCODE_DEBUG_DISCOVERY_SERIAL || '')
+        .trim()
+        .toLowerCase(),
+    ) ||
+    ['1', 'true', 'yes', 'on'].includes(
+      String(process.env.BITCODE_DEBUG_SETUP_SERIAL || '')
+        .trim()
+        .toLowerCase(),
+    );
+  const serialDiscovery = forceSerial || !forceParallel;
+  try {
+    (execution as any).store?.('discovery', 'wave1Serial', serialDiscovery);
+  } catch {
+    /* ignore */
+  }
   const wave1 = serialDiscovery
     ? sequential(
         createAgentExecutor(DISCOVERY_COMPREHEND_CODEBASE),
