Skip to content

Commit 569f4c5

Browse files
authored
feat(field_info): update field-info extension id (#45)
the field_info extension ID was not using the global extensions allocated to aep.dev (as documented in https://github.com/protocolbuffers/protobuf/blob/main/docs/options.md). Fixing that discrepancy, as well as some incorrect documentation.
1 parent 9449990 commit 569f4c5

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ Common types used in AEPs
99

1010
## Protobuf Extensions
1111

12-
aep.dev has registered the extension ids 1253-1263 with the [global extension registry](https://github.com/protocolbuffers/protobuf/blob/main/docs/options.md). Any extensions added to this project should use these values.
12+
aep.dev has registered the extension ids 1264-1274 with the [global extension registry](https://github.com/protocolbuffers/protobuf/blob/main/docs/options.md). Any extensions added to this project should use these values.
1313

1414
To minimize the need to add new ids to the global registry, additions should try to re-use the existing extensions as much as possible (for example, additional field annotations should be added as fields to `aep.api.field_info`).

proto/aep-api/aep/api/field_info.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import "aep/api/field_behavior.proto";
1515
// A field option documenting the applicable lifetime of a field, e.g. an
1616
// idempotency key.
1717
extend google.protobuf.FieldOptions {
18-
FieldInfo field_info = 10520;
18+
FieldInfo field_info = 1265;
1919
}
2020

2121
// Various options related to the behavior of a field.

0 commit comments

Comments
 (0)