Skip to content

Commit 6a048b6

Browse files
authored
docs: add proto extensions to readme, add makefile (#43)
adding proto extension documentation to inform how to add new extensions. adding a makefile to also simplify linting.
1 parent 9858031 commit 6a048b6

6 files changed

Lines changed: 63 additions & 4 deletions

File tree

.github/workflows/lint.yaml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,5 @@ jobs:
1010
container: node:20
1111
steps:
1212
- uses: actions/checkout@v3
13-
- name: Install prettier.
14-
run: npm install --global prettier@3.6.2
15-
- name: Verify proper formatting.
16-
run: prettier --check **/*.md
13+
- name: run lint
14+
run: make lint

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
node_modules

Makefile

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# AEP Components Makefile
2+
3+
.PHONY: lint install
4+
5+
# Install dependencies
6+
install:
7+
npm install
8+
9+
# Run linting with prettier
10+
lint: install
11+
npx prettier --check **/*.md
12+
13+
# Format files with prettier
14+
format: install
15+
npx prettier --write **/*.md

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,9 @@ Common types used in AEPs
66

77
[bsr-aep-conformance]: https://buf.build/aep/conformance
88
[bsr-aep-type]: https://buf.build/aep/type
9+
10+
## Protobuf Extensions
11+
12+
aep.dev has registered the extension ids 1253-1263 with the [global extension registry](https://github.com/protocolbuffers/protobuf/blob/main/docs/options.md). Any extensions added to this project should use these values.
13+
14+
To minimize the need to add new ids to the global registry, additions should try to re-use the existing extensions as much as possible (for example, additional field annotations should be added as fields to `aep.api.field_info`).

package-lock.json

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"name": "aep-components",
3+
"version": "1.0.0",
4+
"description": "AEP (API Enhancement Proposals) components and schemas",
5+
"devDependencies": {
6+
"prettier": "3.6.2"
7+
}
8+
}

0 commit comments

Comments
 (0)