Skip to content

chore: sync core lib and CLAUDE.md from agent-core#12

Merged
avifenesh merged 1 commit intomainfrom
chore/sync-core-consult-20260316-112142
Mar 16, 2026
Merged

chore: sync core lib and CLAUDE.md from agent-core#12
avifenesh merged 1 commit intomainfrom
chore/sync-core-consult-20260316-112142

Conversation

@avifenesh
Copy link
Copy Markdown
Contributor

Automated sync of lib/ and CLAUDE.md from agent-core.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs an automated synchronization of core library files and documentation from the agent-core repository. The primary impact is an update to the git data collection mechanism, transitioning to a new analysis tool and refining the structure of the collected metrics. This ensures the project remains aligned with the latest upstream changes and improvements in data analysis.

Highlights

  • Core Library Sync: Synchronized the lib/ directory and CLAUDE.md file from the agent-core repository, ensuring consistency with the upstream source.
  • Git Data Collection Refactor: Updated the git history collector to use repo-intel instead of git-map for analysis, reflecting a change in the underlying tool or terminology.
  • Git Data Structure Updates: Modified the collected git data to include recentChanges in file activity, add confidence to AI attribution, and simplify conventions by replacing scopes with usesScopes, while also removing the commitShape data.
  • Documentation Updates: Removed the auto-generated comment from CLAUDE.md and refined the 'Token efficiency' guideline for clarity.
Changelog
  • CLAUDE.md
    • Removed the auto-generated header comment.
    • Updated the 'Token efficiency' guideline for conciseness.
  • lib/collectors/git.js
    • Replaced all references to 'git-map' with 'repo-intel' in comments and code.
    • Removed the commitShape property from the collected git data.
    • Added recentChanges to the file activity data structure.
    • Included confidence in the AI attribution data.
    • Replaced scopes with usesScopes in the conventions data structure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, an automated sync from agent-core, introduces several breaking changes to the collectGitData function in lib/collectors/git.js. Specifically, the commitShape property has been removed from the returned object, and within the conventions property, scopes has been replaced by usesScopes. These changes can break downstream consumers of this function. It is recommended to treat this as a major version change and update the PR description and type to reflect the breaking nature of these modifications. The changes in CLAUDE.md are minor and appear to be fine.

conventions: {
style: conventions.style || null,
prefixes: conventions.prefixes || {},
scopes: conventions.scopes || {}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Replacing scopes with usesScopes is a breaking API change. Consumers of collectGitData that rely on the conventions.scopes property will fail. This should be treated as a breaking change and communicated accordingly, for instance by performing a major version bump.

Comment on lines 132 to 136
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The removal of the commitShape property from the object returned by collectGitData is a breaking change for any consumers of this function. Since this function is exported, this could silently break dependent code. This change should be communicated clearly, and if this package is versioned, it likely warrants a major version bump. The PR type chore might be misleading for a breaking change.

@avifenesh avifenesh merged commit e46d652 into main Mar 16, 2026
7 checks passed
@avifenesh avifenesh deleted the chore/sync-core-consult-20260316-112142 branch March 16, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant