Skip to content

security: Inv #12.5 secondLlmRequired has zero producers — #501 closed on a renderer and a green test over an unreachable flag #814

Description

@szhygulin

Verified against canonical agenthill main 504dac0.

Defect

secondLlmRequired is unreachable. Falsifier run — the symbol appears at:

  • src/types/index.ts:1393 (definition)
  • src/signing/render-verification.ts:380,428 (renderer)
  • test/second-llm-required-flag.test.ts (test)

Nowhere else. No producer sets it.

Source says so plainly, render-verification.ts:426: "Today no producer wires it — pure scaffold."

Why this is the sharpest of the scaffold findings

The second-LLM cross-check is the only mechanism in the codebase designed to break the self-attestation loop. Its instruction is exactly right — hand a second, independent model the raw signable bytes and tell it "Do NOT trust payload.description or payload.decoded — the threat is precisely that the first agent narrates X while signing Y."

That is the correct answer to the untrusted-verifier problem. It is scaffold.

Process defect underneath the code defect

#501 closed as delivered. What shipped was a renderer plus a green test over a flag nothing can set. The suite passes; the control does not exist. A passing test over dead scaffold is worse than no test — it reads as coverage.

Worth asking whether other closed security issues have the same shape (#460 is one — producer half only).

Ask

  1. wire a producer, or
  2. reopen [security] Add Invariant #12.5 — hard-trigger ops list requiring mandatory second-LLM #501 as not-delivered and state the trigger condition, or
  3. delete the scaffold and stop counting Inv Auto-discover Morpho Blue positions via event-log scan #12.5 as a control

Related: #501 (closed), #460, #776.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecurity_findingSecurity gap surfaced via adversarial smoke-test

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions