Skip to content

Commit ceccbee

Browse files
Update tests
1 parent b4af8da commit ceccbee

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

tests/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ def sssp(generate_upf_data_for_session):
299299
filename = f"{element}_{'_'.join(params.values())}.upf"
300300
upf = generate_upf_data_for_session(element, filename, params)
301301
upf.store()
302+
upf.base.extras.set("functional", functional)
302303
nodes.append(upf)
303304
family.add_nodes(nodes)
304305
family.set_cutoffs(CUTOFFS, accuracy, unit="Ry")
@@ -325,6 +326,7 @@ def pseudodojo(generate_upf_data_for_session):
325326
filename = f"{element}_{'_'.join(params.values())}.upf"
326327
upf = generate_upf_data_for_session(element, filename, params)
327328
upf.store()
329+
upf.base.extras.set("functional", functional)
328330
nodes.append(upf)
329331
family.add_nodes(nodes)
330332
family.set_cutoffs(CUTOFFS, stringency, unit="Ry")

tests/test_pseudo.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,12 +373,16 @@ def test_missing_pseudos(generate_structure_data):
373373
assert "does not contain a pseudopotential for Ce" in model.blockers[0] # type: ignore
374374

375375

376-
def test_functional_mismatch_blocker(generate_structure_data):
376+
def test_functional_mismatch_blocker(generate_structure_data, generate_upf_data):
377377
"""Test blocker for inconsistent functional across selected pseudopotentials."""
378378
model = PseudosConfigurationSettingsModel()
379379
_ = PseudosConfigurationSettingsPanel(model=model)
380380
model.structure_uuid = generate_structure_data("silica").uuid
381-
model.functionals = ["PBE", "PBEsol"]
381+
pseudo1 = generate_upf_data("Si", "Si_PBE.upf").store()
382+
pseudo1.base.extras.set("functional", "PBE")
383+
pseudo2 = generate_upf_data("O", "O_PBEsol.upf").store()
384+
pseudo2.base.extras.set("functional", "PBEsol")
385+
model.dictionary = {"Si": pseudo1.uuid, "O": pseudo2.uuid}
382386
assert len(model.blockers) == 1
383387
assert "must have the same exchange-correlation" in model.blockers[0] # type: ignore
384388

0 commit comments

Comments
 (0)