🧪 Assert shell warning via node logs (#120)

Use the node log records instead of pytest log capture for this
assertion. The warning is still emitted, but it no longer reliably
appears in captured log records with the recent AiiDA logging changes.

Author: agoscinski

tests/calculations/test_shell.py

@@ -6,7 +6,7 @@
 import pytest
 from aiida.common.datastructures import CodeInfo
 from aiida.engine import run_get_node
-from aiida.orm import Data, Float, FolderData, Int, List, RemoteData, SinglefileData, Str
+from aiida.orm import Data, Float, FolderData, Int, List, Log, RemoteData, SinglefileData, Str
 
 from aiida_shell.calculations.shell import ShellJob
 from aiida_shell.data import EntryPointData, PickledData
@@ -453,7 +453,7 @@ def parser(dirpath):
     assert node.outputs.string == value
 
 
-def test_input_output_filename_overlap(generate_calc_job, generate_code, tmp_path, caplog):
+def test_input_output_filename_overlap(generate_calc_job, generate_code, tmp_path):
     """Test functionality when input and output filenames overlap."""
     code = generate_code()
 
@@ -481,18 +481,22 @@ def test_input_output_filename_overlap(generate_calc_job, generate_code, tmp_pat
 
     # If the filename clash is due to an "implicit" filename, instead of raising, the filename of the node should be
     # automatically made unique and a warning logged to make the user aware.
-    dirpath, calc_info = generate_calc_job(
-        'core.shell',
-        inputs={
+    def generate_inputs():
+        return {
             'code': code,
             'nodes': {'file': SinglefileData.from_string('content', filename='stdout')},
-        },
-    )
+        }
+
+    dirpath, calc_info = generate_calc_job('core.shell', inputs=generate_inputs())
+    process = generate_calc_job('core.shell', inputs=generate_inputs(), return_process=True)
+
     code_info = calc_info.codes_info[0]
     filenames = [p.name for p in dirpath.iterdir()]
     assert code_info.stdout_name not in filenames
     assert code_info.stderr_name not in filenames
-    assert 'filename `stdout` for node `file` overlaps' in caplog.records[0].message
+
+    message = 'filename `stdout` for node `file` overlaps'
+    assert any(message in entry.message for entry in Log.collection.get_logs_for(process.node))
 
     # If the contents of a ``FolderData`` overlap with a reserved filename, an exception is raised. This is done because
     # not doing everything will most likely fail the calculation as some input files will be overwritten. The plugin can